Avro 2918 poly with compiler #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } else | ||
| a0.clear(); | ||
| SpecificData.Array<java.lang.CharSequence> ga0 = (a0 instanceof SpecificData.Array | ||
| ? (SpecificData.Array<java.lang.CharSequence>) a0 |
Check warning
Code scanning / CodeQL
Cast from abstract to concrete collection
| } else | ||
| a1.clear(); | ||
| SpecificData.Array<java.lang.Integer> ga1 = (a1 instanceof SpecificData.Array | ||
| ? (SpecificData.Array<java.lang.Integer>) a1 |
Check warning
Code scanning / CodeQL
Cast from abstract to concrete collection
| } else | ||
| a0.clear(); | ||
| SpecificData.Array<java.lang.CharSequence> ga0 = (a0 instanceof SpecificData.Array | ||
| ? (SpecificData.Array<java.lang.CharSequence>) a0 |
Check warning
Code scanning / CodeQL
Cast from abstract to concrete collection
| } else | ||
| a1.clear(); | ||
| SpecificData.Array<java.lang.Integer> ga1 = (a1 instanceof SpecificData.Array | ||
| ? (SpecificData.Array<java.lang.Integer>) a1 |
Check warning
Code scanning / CodeQL
Cast from abstract to concrete collection
| generic.put("hash", | ||
| new GenericData.Fixed(MD5.SCHEMA$, new byte[] { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 0, 1, 2, 3, 4, 5 })); | ||
| TestRecord specific = (TestRecord) SpecificData.get().deepCopy(TestRecord.SCHEMA$, generic); | ||
| TestRecord specific = (TestRecord) SpecificData.get().deepCopy(TestRecord.getClassSchema(), generic); |
Check notice
Code scanning / CodeQL
Unread local variable
lang/java/compiler/src/test/java/org/apache/avro/compiler/specific/TestSpecificCompiler.java
Fixed
Show fixed
Hide fixed
clesaec
force-pushed
the
avro-2918_PolyWithCompiler
branch
from
83f4bbf to
8968ca0
Compare
lang/java/compiler/src/test/java/org/apache/avro/compiler/specific/TestSpecificCompiler.java
Fixed
Show fixed
Hide fixed
lang/java/compiler/src/test/java/org/apache/avro/compiler/specific/TestSpecificCompiler.java
Fixed
Show fixed
Hide fixed
clesaec
force-pushed
the
avro-2918_PolyWithCompiler
branch
from
8968ca0 to
65568a3
Compare
clesaec
force-pushed
the
avro-2918_PolyWithCompiler
branch
from
63e2742 to
575feb9
Compare
author Christophe Le Saec <clesaec@talend.com> 1658414469 +0200 committer Christophe Le Saec <clesaec@talend.com> 1702483472 +0100 gpgsig -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEik1F1e1qC/83ZVhPUZ9LZmkJEUAFAmV51hAACgkQUZ9LZmkJ EUC6Qw//WE43vrjCqYrjaoCMGEjJui616MvKFCUtwILmoE8GU2aP/y2odP7jAnvJ 04RJHMaC03sV61kta0RYarPcCxaewu4Up/c+0RVNWqDb6gZZHA8hWW9I5TZdk106 JXdSeyjSy45MUJPPM1xwrI+5+ZfTC9gtYxb7iXQI8fNmN9x+a91x1L1GViSXMRAF DSPlLgYteFZvTFw4jdwndCrKL1BcyPWfF5p984kEI4hW0Gemm/+bTM90dwSBP0bN PvePHJ9rpkwo8j8xdyNSNWvomN7sUYDF4c5AKHQfVpzbNxTrYBjkGi/tqF4BQx9j yP4jvEvzQmg2yUmapNMmqGkwh2h7MQo2kQMEjKFvQuyBxsgIzonb+gw2+Y8L2iVG 0BzDlFVdeKiWiOsBdXSjWa1Cfjbva9UsrrvcX5WIuXflcDQdvRlHXHBCrk0x6jQt /SqoANMnA8zssj4Wk5aWIS1TcO/Gupe2OBAJUjd98BkgklJ4NuD529vubmgLYFyE QzxVdTCCJRJIUklEMOGXRMkdI1tamw6W8Q4yPTRSoHwYpy8UZCCmbVusY5HGoYSb 7OCa9szFV55F8J07ZN8USh2aJ9AxtRxr6MQo+LKvNDIR5hz2UNmizQHdvdMnbT24 jeYVSjdlgDI76sB+7QXwACQXUqv6mFEKzVVhubLErIw8MigNw+Y= =DXiY -----END PGP SIGNATURE----- AVRO-2918: First proposition for polymorphism AVRO-2918: poly AVRO-2918: fix fast reader AVRO-2918: retrieve unused class AVRO-2918: fix unit test AVRO-2918: rebased done AVRO-2918: First proposition for polymorphism AVRO-2918: include generated code AVRO-2918: add Apache license AVRO-2918: fix generated record AVRO-2918: Adapt unit test AVRO-2918: fix deprecated AVRO-2918: fix compiler
clesaec
force-pushed
the
avro-2918_PolyWithCompiler
branch
from
575feb9 to
820f54b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
(For example: This pull request improves file read performance by buffering data, fixing AVRO-XXXX.)
Verifying this change
(Please pick one of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation