Add heap stats logging to Service#1238
Merged
elrayle merged 11 commits intoDec 12, 2024
Merged
Conversation
mpcen
approved these changes
Nov 20, 2024
qtomlinson
reviewed
Nov 27, 2024
Collaborator
qtomlinson
left a comment
There was a problem hiding this comment.
Thank you for adding another tool to our troubleshooting toolkit!
Collaborator
qtomlinson
reviewed
Dec 5, 2024
qtomlinson
approved these changes
Dec 5, 2024
Collaborator
qtomlinson
left a comment
There was a problem hiding this comment.
Thanks for the detailed documentation!
elrayle
approved these changes
Dec 11, 2024
Collaborator
elrayle
left a comment
There was a problem hiding this comment.
Made the Copyright change a suggestion so we can get this merged.
qtomlinson
approved these changes
Dec 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It would be useful to gain insight into memory usage in helping to debug runtime issues.
Work Done
v8npm package to gather heap usage statisticsLOG_NODE_HEAPSTATStrueorfalse(case insensitive) to enable the heap stats loggingLOG_NODE_HEAPSTATS_INTERVAL_MSnumber(inmilliseconds) representing the interval to log heap stats at<type>.env.jsonfiles to add new env vars for visibilityconfig.jsto look for new env var values