RLE decoder update #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix proposed by Pinobatch (aka Tepples) aims to improve the decoder compatibility for nametables that have no unused tile, as in all 256 CHR tiles were used. The improvement consists of the following change: if a read byte is the tag but is followed by a "01" that means the tag won't act as a tag, but as data. An updated encoder must be used to make full use of the new logic, but this updated version can also be used to fully load previously encoded RLE data that use fewer than 256 tiles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix proposed by Pinobatch (aka Tepples) aims to improve the decoder compatibility for nametables that have no unused tile, as in all 256 CHR tiles were used. Original thread: https://forums.nesdev.org/viewtopic.php?p=224941#p224941
The improvement consists of the following change: if a read byte is the tag but is followed by a "01" that means the tag won't act as a tag, but as data.
An updated encoder must be used to make full use of the new logic, but this updated version can also be used to fully load previously encoded RLE data that use fewer than 256 tiles.