refactor: uikit#640
Draft
claration wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt on rewriting Feather in UIKit instead of SwiftUI.
The reason I chose to do this because of my own sake, I find SwiftUI extremely difficult to maintain most of the time and lack a lot of the quality standards that I aim to provide in my apps, like Protokolle and Antrag (though, some parts are still SwiftUI due to convenience in these, implemented in ways that do not interfere with the apps performance or maintainability).
The original rewrite of Feather was in SwiftUI, mainly because of wanting more contributions out of users, but unfortunately this had more issues than benefits. For example, I had to drop iOS 15 support due to SwiftUI equivalent to UIKit API's only supporting higher versions than what they should be (the framework is still fairly new).
This won't be done like the rush I had with v2.0, I don't want another sloppy codebase that I don't want to touch.
Note: I may not even finish or go through with this rewrite, Feather is a monsterous app that has many features users want, the rewrite should contain all of these existing features.