fix(lr-9cfc): address PEACHES blocking findings B1/B2/B3#150
Closed
akuehner wants to merge 1 commit into
Closed
Conversation
B1 — remove registerClaim loop from attachAgentSession: pre-existing conversations are now display-only per task spec. Operator decides per-conversation; no auto-claim at session open to avoid recreating the stale-claim/zombie-blocking pattern fixed 2026-05-19. B2 — replace hardcoded X-Relay-Caller-Lead: "andy" with CLAGENTIC_OPERATOR_LEAD env var (falls back to empty string). Relay treats absent header as anonymous operator access — safe for UI-path sessions. No personal identifier in platform code (rule 11). B3 — wire onNewConversation call site via sidecar directory watcher (startSidecarWatcher). Fires onNewConversation when a new sidecar appears with agentName as participant. Watcher starts in attachAgentSession (relay-present path) and closes in detachAgentSession. Self-contained in relay-agent-claims.js; project-sessions.js unchanged. Nits also addressed: - Fix error message rendering "undefined: <msg>" when parsed.error is missing in relayPost (nit 5). - Export registerClaim/heartbeatClaim/releaseClaim for test use. - Add onNewConversation relay-absent no-op tests (nit 6). - Add fake Unix-socket relay server test covering register/heartbeat/ release HTTP paths (nit 7). - Update test header comment to match actual coverage.
Member
Author
|
Superseded by #148 which merged first. Same B1/B2/B3 fixes — this branch conflicts with main post-merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
B1 — remove registerClaim loop from attachAgentSession: pre-existing conversations are now display-only per task spec. Operator decides per-conversation; no auto-claim at session open to avoid recreating the stale-claim/zombie-blocking pattern fixed 2026-05-19.
B2 — replace hardcoded X-Relay-Caller-Lead: "andy" with CLAGENTIC_OPERATOR_LEAD env var (falls back to empty string). Relay treats absent header as anonymous operator access — safe for UI-path sessions. No personal identifier in platform code (rule 11).
B3 — wire onNewConversation call site via sidecar directory watcher (startSidecarWatcher). Fires onNewConversation when a new sidecar appears with agentName as participant. Watcher starts in attachAgentSession (relay-present path) and closes in detachAgentSession. Self-contained in relay-agent-claims.js; project-sessions.js unchanged.
Nits also addressed: