Keep external drop effect as copy#20185
Open
HardyPotato wants to merge 1 commit into
Open
Conversation
Author
|
This PR was recreated from current upstream Current head: The CLA checker page still renders no PR status/commit block for this PR: https://cla.ckeditor.com/check/ckeditor/ckeditor5/20185 The contributor has completed the CLA flow from the |
This was referenced May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Summary
Keeps external drag operations advertised as
copyin the clipboard drag/drop plugin.The
dragginghandler already detects external drags with!this._draggedRangeand setsdataTransfer.dropEffect = 'copy'. In non-Gecko browsers, the next branch could immediately overwrite that value tomovewheneffectAllowedwasallorcopyMove.This change only runs the non-Gecko
effectAllowedfallback for internal editor drags. External drags keep the explicitcopydrop effect.📌 Related issues
💡 Additional information
Manually verified using the clipboard drag/drop manual test page in Chromium. External file drags over the editor no longer forced
dropEffect = "move".Automated regression coverage added in
packages/ckeditor5-clipboard/tests/dragdrop.js.Checked locally with:
npx pnpm@10.28.0 run test --files=clipboard/dragdrop🧾 Checklists
Author checklist
Reviewer checklist
t()(if any).