fix: Move title TOC computation to frontmatter to fix esbuild build failure#106
Merged
williamzujkowski merged 1 commit intomainfrom Mar 30, 2026
Merged
fix: Move title TOC computation to frontmatter to fix esbuild build failure#106williamzujkowski merged 1 commit intomainfrom
williamzujkowski merged 1 commit intomainfrom
Conversation
esbuild fails with "Expected identifier but found const" when Astro templates contain const declarations inside .map() callbacks. Fix by pre-computing all chapter and section view data in the frontmatter section using typed interfaces (ChapterView, SectionView). This also removes the onclick="event.stopPropagation()" which was flagged as another esbuild issue. Build verified: 58,032 pages in 294s locally. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Build fails with
Expected identifier but found "const"— esbuild can't handleconstdeclarations inside.map()callbacks in Astro templates. This was introduced in PR #103 (chapter hints) and broke all CI/deploy builds.Fix
Move ALL template-level computation to the Astro frontmatter section:
ChapterViewandSectionViewtyped interfacesconst, no.map()with logic)Verified
svelte-check: 0 errorspnpm test: all passRoot cause
Astro compiles template expressions to JS that esbuild processes. Complex callback logic with
constin arrow functions generates invalid JS in esbuild's parser context. Moving computation to frontmatter avoids this entirely.🤖 Generated with Claude Code