fix(ci): strip attacker-controlled Claude/MCP config in PR workflows#626
Open
m1amgn wants to merge 2 commits into
Open
fix(ci): strip attacker-controlled Claude/MCP config in PR workflows#626m1amgn wants to merge 2 commits into
m1amgn wants to merge 2 commits into
Conversation
PR trees are attacker-controlled and run through `claude` on a self-hosted runner with clean: false. A PR carrying .claude/settings.json (SessionStart hooks) or .mcp.json (MCP servers) would execute arbitrary commands as the runner user. Remove those files after checkout (after rebase in pr-fix to avoid dirtying the tree) and load the fullstack.md persona from the trusted origin/dev blob instead of the PR tree to prevent system-prompt injection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR trees are attacker-controlled and run through
claudeon a self-hosted runner with clean: false. A PR carrying .claude/settings.json (SessionStart hooks) or .mcp.json (MCP servers) would execute arbitrary commands as the runner user. Remove those files after checkout (after rebase in pr-fix to avoid dirtying the tree) and load the fullstack.md persona from the trusted origin/dev blob instead of the PR tree to prevent system-prompt injection.#616: fixed bug with menus