ci: fix release-please wiring#140
Merged
ashutosh-ukey merged 1 commit intocirclefin:masterfrom Mar 19, 2026
Merged
Conversation
nexx88
approved these changes
Mar 18, 2026
tomleicircle
approved these changes
Mar 18, 2026
ashutosh-ukey
pushed a commit
that referenced
this pull request
Mar 19, 2026
🤖 I have created a release *beep* *boop* --- ## [2.10.1](v2.10.0...v2.10.1) (2026-03-19) ### Continuous Integration * fix release-please wiring ([#140](#140)) ([27f4efe](27f4efe)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
nexx88
pushed a commit
that referenced
this pull request
Mar 20, 2026
## Summary Restore `id-token: write` in the reusable npm publish workflow so AWS OIDC auth works during publish ### Why - the publish pipeline is failing in `Configure AWS Credentials` before `npm publish` - `aws-actions/configure-aws-credentials` is using `role-to-assume`, which requires a GitHub OIDC token - the workflow only grants `contents: read`, so the job cannot mint that token ## Details ### Regression Context - `id-token: write` was originally added in [`ffcaf51`](ffcaf51) (`fix: allow OIDC token in publish pipeline (#25)`) - it was removed in [`40ee83f`](40ee83f) (`chore(stepsecurity): update workflows to use custom hosted runners with built-in StepSecurity (#133)`) - that regression stayed hidden until [`27f4efe`](27f4efe) (`ci: fix release-please wiring (#140)`) fixed release gating and caused `npm-publish` to run again ## Validation - reviewed failed run [`23300901189`](https://github.com/circlefin/circle-nodejs-sdk/actions/runs/23300901189) and failing job [`67761702334`](https://github.com/circlefin/circle-nodejs-sdk/actions/runs/23300901189/job/67761702334) - confirmed the job fails in `Configure AWS Credentials` with the log: `Did you mean to set the id-token permission?`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The release workflow was checking
needs.release-please.outputs.did-create-release, but Circle's sharedconventional-commit-releaseworkflow exposesrelease_createdinstead. This caused thenpm-publishjob to be skipped even after a release was created. This change updates the condition to userelease_createdso npm publishing follows the actual shared workflow output contract.Changes
.github/workflows/release.ymlto gatenpm-publishonneeds.release-please.outputs.release_createdrelease-sbomValidation
23267482209release_createdrelease_createdfor downstream gating