Skip to content

Spec moving sorting optimizations for 1 key to the Sorter itself #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jtnelson wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Spec moving sorting optimizations for 1 key to the Sorter itself #566

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b04aa9b
spec out moving this to the StoreSorter
jtnelson Apr 28, 2025
931569c
update documentation
jtnelson Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
126 changes: 82 additions & 44 deletions concourse-server/src/main/java/com/cinchapi/concourse/server/query/sort/StoreSorter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,14 @@
*/
package com.cinchapi.concourse.server.query.sort;

import java.util.ArrayList;
import java.util.Collection;
import java.util.Comparator;
import java.util.List;
import java.util.Map;
import java.util.Map.Entry;
import java.util.Set;
import java.util.stream.Collectors;
import java.util.stream.Stream;

import javax.annotation.Nullable;
Expand All @@ -30,6 +35,7 @@
import com.cinchapi.concourse.lang.sort.Order;
import com.cinchapi.concourse.lang.sort.OrderComponent;
import com.cinchapi.concourse.server.storage.Store;
import com.google.common.collect.Lists;

/**
* A {@link StoreSorter} imposes an {@link Order} by value on a result set. The
Expand Down Expand Up @@ -72,56 +78,88 @@ public final Stream<Entry<Long, Map<String, V>>> sort(
@Override
public final Stream<Entry<Long, Map<String, V>>> sort(
Stream<Entry<Long, Map<String, V>>> stream, @Nullable Long at) {
ArrayBuilder<Comparator<Entry<Long, Map<String, V>>>> comparators = ArrayBuilder
.builder();
for (OrderComponent component : order.spec()) {
List<OrderComponent> spec = order.spec();
if(spec.size() == 1) {
OrderComponent component = spec.get(0);
String key = component.key();
Timestamp timestamp = component.timestamp();
Direction direction = component.direction();
Comparator<Entry<Long, Map<String, V>>> $comparator = (e1, e2) -> {
long r1 = e1.getKey();
long r2 = e2.getKey();
Map<String, V> d1 = e1.getValue();
Map<String, V> d2 = e2.getValue();
V v1;
V v2;
if(timestamp == null) {
v1 = d1.get(key);
if(v1 == null) {
v1 = at != null ? lookup(key, r1, at) : lookup(key, r1);
Timestamp timestamp = component.timestamp();
// TODO: check corner case of no timestamp provided, but there is an
// operation timestamp
// TODO: test
Collection<Set<Long>> sorted = timestamp == null
? store.browse(key).values()
: store.browse(key, timestamp.getMicros()).values();
Map<Long, Entry<Long, Map<String, V>>> entries = stream
.collect(Collectors.toMap(Entry::getKey, entry -> entry));
Stream<Set<Long>> $;
if(direction == Direction.ASCENDING) {
$ = sorted.stream();
}
else {
$ = Lists.reverse(new ArrayList<>(sorted)).stream();
}
return $.flatMap(bucket -> bucket.stream())
.map(record -> entries.get(record))
.filter(entry -> entry != null);
}
else {
ArrayBuilder<Comparator<Entry<Long, Map<String, V>>>> comparators = ArrayBuilder
.builder();
for (OrderComponent component : order.spec()) {
String key = component.key();
Timestamp timestamp = component.timestamp();
Direction direction = component.direction();
Comparator<Entry<Long, Map<String, V>>> $comparator = (e1,
e2) -> {
long r1 = e1.getKey();
long r2 = e2.getKey();
Map<String, V> d1 = e1.getValue();
Map<String, V> d2 = e2.getValue();
V v1;
V v2;
if(timestamp == null) {
v1 = d1.get(key);
if(v1 == null) {
v1 = at != null ? lookup(key, r1, at)
: lookup(key, r1);
}
v2 = d2.get(key);
if(v2 == null) {
v2 = at != null ? lookup(key, r2, at)
: lookup(key, r2);
}
}
else {
v1 = lookup(key, r1, timestamp.getMicros());
v2 = lookup(key, r2, timestamp.getMicros());
}
if(!Empty.ness().describes(v1)
&& !Empty.ness().describes(v2)) {
// The coefficient is only applied when both values are
// non-empty. Otherwise, the empty value should float to
// the end of the sort, regardless of the specified
// direction
return direction.coefficient() * compare(v1, v2);
}
else if(!Empty.ness().describes(v1)) {
return -1;
}
else if(!Empty.ness().describes(v2)) {
return 1;
}
v2 = d2.get(key);
if(v2 == null) {
v2 = at != null ? lookup(key, r2, at) : lookup(key, r2);
else {
return 0;
}
}
else {
v1 = lookup(key, r1, timestamp.getMicros());
v2 = lookup(key, r2, timestamp.getMicros());
}
if(!Empty.ness().describes(v1) && !Empty.ness().describes(v2)) {
// The coefficient is only applied when both values are
// non-empty. Otherwise, the empty value should float to the
// end of the sort, regardless of the specified direction
return direction.coefficient() * compare(v1, v2);
}
else if(!Empty.ness().describes(v1)) {
return -1;
}
else if(!Empty.ness().describes(v2)) {
return 1;
}
else {
return 0;
}

};
comparators.add($comparator);
};
comparators.add($comparator);
}
comparators.add((e1, e2) -> e1.getKey().compareTo(e2.getKey()));
Comparator<Entry<Long, Map<String, V>>> comparator = CompoundComparator
.of(comparators.build());
return stream.sorted(comparator);
}
comparators.add((e1, e2) -> e1.getKey().compareTo(e2.getKey()));
Comparator<Entry<Long, Map<String, V>>> comparator = CompoundComparator
.of(comparators.build());
return stream.sorted(comparator);
}

/**
Expand Down