Springboot Version update #16
Conversation
| @@ -1,7 +1,7 @@ | |||
| plugins | |||
| /*plugins | |||
There was a problem hiding this comment.
This whole comment out section should be removed.
| //*/ | ||
| plugins | ||
| { | ||
| id 'org.springframework.boot' version '3.3.5' |
There was a problem hiding this comment.
A higher stable version is available, we should move to that.
| sourceCompatibility = JavaVersion.VERSION_17 | ||
| targetCompatibility = JavaVersion.VERSION_17 | ||
| } | ||
| //java |
There was a problem hiding this comment.
Clean-up and remove all old comments please.
| // url "https://public.dhe.ibm.com/ibmdl/export/pub/software/websphere/maven/repository/" | ||
| //} | ||
| } | ||
| dependencies { |
There was a problem hiding this comment.
Remove commented out libraries, and add good comments to each library that is used.
| // Not needed | ||
| //implementation("org.springframework.boot:spring-boot-starter-actuator") | ||
| // Use correct BOM version for CICS TS | ||
| compileOnly(enforcedPlatform("com.ibm.cics:com.ibm.cics.ts.bom:6.2-20250528120756-PH65227")) |
There was a problem hiding this comment.
We should level-set on CICS TS V6.1 as our min CICS release - add a comment to suggest users can move to a higher level of BOM to match their target CICS region.
| //{ | ||
| // enabled = false // disable plain WAR, use bootWar instead | ||
| //} | ||
| publishing { |
There was a problem hiding this comment.
I'm not clear on why this section has changed from the original?
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-starter-parent</artifactId> | ||
| <version>2.7.0</version> | ||
| <version>3.3.5</version> |
There was a problem hiding this comment.
Version need updating.
| <groupId>com.ibm.cics</groupId> | ||
| <artifactId>com.ibm.cics.ts.bom</artifactId> | ||
| <version>5.5-20200519131930-PH25409</version> | ||
| <version>6.1-20240903141936-PH59389</version> |
There was a problem hiding this comment.
Comment above doesn't match version.
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-starter-web</artifactId> | ||
| </dependency> | ||
| <dependency> |
There was a problem hiding this comment.
This dependency has been separated from it's comment above and needs to be matched back up.
| import org.springframework.boot.SpringApplication; | ||
| import org.springframework.boot.autoconfigure.SpringBootApplication; | ||
|
|
||
|
|
There was a problem hiding this comment.
Copyright licence has been lost.
| { | ||
| SpringApplication.run(Application.class, args); | ||
| } | ||
| public class Application { |
There was a problem hiding this comment.
brackets should be CICS style, and not end-of-line.
IvanHargreaves
left a comment
IvanHargreaves
left a comment
There was a problem hiding this comment.
Hi Manvi. I've made various comments on the PR, hopefully you can work your way through them asking questions and learning about the types of rigour and best-practice we apply to the samples.
2 participants
No description provided.