Skip to content

Fix calculate-position for @renderInPlace={{false}} #1050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkszepp merged 1 commit into from
Dec 24, 2025
Merged

Fix calculate-position for @renderInPlace={{false}} #1050

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions src/utils/calculate-position.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,18 @@ type GetViewDataResult = {
type GetViewData = (
trigger: Element,
content: HTMLElement,
renderInPlace: boolean,
) => GetViewDataResult;

const getViewData: GetViewData = (trigger, content) => {
const scroll = {
left: window.scrollX,
top: window.scrollY,
};
const getViewData: GetViewData = (trigger, content, renderInPlace) => {
let scroll = { left: window.pageXOffset, top: window.pageYOffset };
if (renderInPlace) {
scroll = {
left: window.scrollX,
top: window.scrollY,
};
}

const {
left: triggerLeft,
top: triggerTop,
Expand All @@ -72,8 +77,8 @@ const getViewData: GetViewData = (trigger, content) => {
// The properties top and left of the trigger client rectangle need to be absolute to
// the top left corner of the document as the value it's compared to is also the total
// height and not only the viewport height (window client height + scroll offset).
triggerLeft: triggerLeft + window.scrollX,
triggerTop: triggerTop + window.scrollY,
triggerLeft: triggerLeft + (renderInPlace ? window.scrollX : 0),
triggerTop: triggerTop + (renderInPlace ? window.scrollY : 0),
triggerWidth,
triggerHeight,
dropdownHeight,
Expand All @@ -96,7 +101,7 @@ export function calculateWormholedPosition(
}: CalculatePositionOptions,
): CalculatePositionResult {
// Collect information about all the involved DOM elements
const viewData = getViewData(trigger, content);
const viewData = getViewData(trigger, content, false);
const {
scroll,
triggerWidth,
Expand Down Expand Up @@ -293,7 +298,7 @@ export function calculateInPlacePosition(
} else {
// Automatically determine if there is enough space above or below
const { triggerTop, triggerHeight, dropdownHeight, viewportBottom } =
getViewData(trigger, content);
getViewData(trigger, content, true);

const enoughRoomBelow =
triggerTop + triggerHeight + dropdownHeight < viewportBottom;
Expand Down