Add "scan" and "add" context menu options within the ROM list #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
. Add alternative argument parameter for each items. . Change version number
add alternative argument option for each items.
. Fix negative handle problem. . Fix TheGameDB cached thumbs images display list
. Fix message display for launchers fanart image change. . Fix message display for items fanart image change.
Fix GameFAQs thumbs and fanarts scrapers.
. Fix GameFAQs gamesystem reference list.
to show/hide finished categories/launcher/items. Improve launchers.xml file parsing. Fix compatibility with launchers.xml files created from 2.0.0 prior versions.
. Fix empty query launcher bug. . Code cleaning.
Suspend audio regardless of mediastate
Update README.md
… be added from within the corresponding ROM list (i.e., similarly to "Update library" for videos).
Author
|
Weird...the CI build seems to think this project is Ruby...perhaps the CI build should just be disabled? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a usability issue with AdvancedLauncher: when looking at the list of ROMs for a given launcher, it's not at all obvious how to get AL to scan for new ROMs, or to manually add a new ROM, because these options are not available in this view: you have to navigate up a level, as these are context menu items on the launcher itself.
The simple fix is to also add these options to each ROM's ListItem. While "rescan" is logically an operation on the launcher itself, and not the individual ROMs, Kodi has already set a precedent, by having "Update library" available as a context menu item within video directories, so this change makes AL more consistent with the rest of Kodi.