Skip to content

feat(datepicker): add aria labels and aria level #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vbergeron-ls wants to merge 7 commits into
base: master
Choose a base branch
from
Open

feat(datepicker): add aria labels and aria level #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
05dc259
chore(build): Test write rights
vbergeron-ls Feb 4, 2026
83b431e
feat(datepicker): add aria labels and aria level
vbergeron-ls Feb 9, 2026
ec3b34b
feat(datepicker): remove heading level
vbergeron-ls Feb 10, 2026
7a711ef
feat(datepicker): remove heading level for year and month pickers
vbergeron-ls Feb 11, 2026
3b1e465
feat(datepicker): expose options for each datepicker type
vbergeron-ls Feb 13, 2026
ef55cfe
feat(datepicker): fix merge removing tabindex from title
vbergeron-ls Feb 13, 2026
2909c4b
feat(datepicker): fix merge weirdness
vbergeron-ls Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions src/datepicker/datepicker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,12 @@ angular.module('ui.bootstrap.datepicker', ['ui.bootstrap.dateparser', 'ui.bootst
minMode: 'day',
monthColumns: 3,
ngModelOptions: {},
nextMonthLabel: 'Next month',
nextYearLabel: 'Next year',
nextYearsLabel: 'Next 20 years',
Copy link

@olimart olimart Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • does the datepicker limit to the next 20 years?
  • no translation supported I guess?

Copy link
Author

@vbergeron-ls vbergeron-ls Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Yep because in years view, the grid displays 20 years at a time
  2. This is essentially the default value when nothing is provided to the datepicker (because this repo does not support localization) but we will provide localized labels from chronogolf.

previousMonthLabel: 'Previous month',
previousYearLabel: 'Previous year',
previousYearsLabel: 'Previous 20 years',
shortcutPropagation: false,
showWeeks: true,
yearColumns: 5,
Expand Down Expand Up @@ -56,6 +62,12 @@ angular.module('ui.bootstrap.datepicker', ['ui.bootstrap.dateparser', 'ui.bootst
'minDate',
'minMode',
'monthColumns',
'nextMonthLabel',
'nextYearLabel',
'nextYearsLabel',
'previousMonthLabel',
'previousYearLabel',
'previousYearsLabel',
'showWeeks',
'shortcutPropagation',
'startingDay',
Expand Down Expand Up @@ -89,6 +101,15 @@ angular.module('ui.bootstrap.datepicker', ['ui.bootstrap.dateparser', 'ui.bootst
self[key] = angular.isDefined($scope.datepickerOptions[key]) ?
$scope.datepickerOptions[key] : datepickerConfig[key];
break;
case 'nextMonthLabel':
case 'nextYearLabel':
case 'nextYearsLabel':
case 'previousMonthLabel':
case 'previousYearLabel':
case 'previousYearsLabel':
$scope[key] = angular.isDefined($scope.datepickerOptions[key]) ?
$scope.datepickerOptions[key] : datepickerConfig[key];
break;
case 'startingDay':
if (angular.isDefined($scope.datepickerOptions.startingDay)) {
self.startingDay = $scope.datepickerOptions.startingDay;
Expand Down
6 changes: 3 additions & 3 deletions template/datepicker/day.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<table role="grid" aria-labelledby="{{::uniqueId}}-title" aria-activedescendant="{{activeDateId}}">
<thead>
<tr>
<th><button type="button" class="btn btn-default btn-sm pull-left uib-left" ng-click="move(-1)" tabindex="0" aria-label="Previous month"><i aria-hidden="true" class="glyphicon glyphicon-chevron-left"></i><span class="sr-only">previous</span></button></th>
<th colspan="{{::5 + showWeeks}}"><button id="{{::uniqueId}}-title" role="heading" aria-live="assertive" aria-atomic="true" type="button" class="btn btn-default btn-sm uib-title" ng-click="toggleMode()" ng-disabled="datepickerMode === maxMode" tabindex="0"><strong>{{title}}</strong></button></th>
<th><button type="button" class="btn btn-default btn-sm pull-right uib-right" ng-click="move(1)" tabindex="0" aria-label="Next month"><i aria-hidden="true" class="glyphicon glyphicon-chevron-right"></i><span class="sr-only">next</span></button></th>
<th><button type="button" class="btn btn-default btn-sm pull-left uib-left" ng-click="move(-1)" tabindex="0" aria-label="{{::previousMonthLabel}}"><i aria-hidden="true" class="glyphicon glyphicon-chevron-left"></i><span class="sr-only">{{::previousMonthLabel}}</span></button></th>
<th colspan="{{::5 + showWeeks}}"><button id="{{::uniqueId}}-title" aria-live="assertive" aria-atomic="true" type="button" class="btn btn-default btn-sm uib-title" ng-click="toggleMode()" ng-disabled="datepickerMode === maxMode" tabindex="0"><strong>{{title}}</strong></button></th>
<th><button type="button" class="btn btn-default btn-sm pull-right uib-right" ng-click="move(1)" tabindex="0" aria-label="{{::nextMonthLabel}}"><i aria-hidden="true" class="glyphicon glyphicon-chevron-right"></i><span class="sr-only">{{::nextMonthLabel}}</span></button></th>
</tr>
<tr>
<th ng-if="showWeeks" class="text-center"></th>
Expand Down
6 changes: 3 additions & 3 deletions template/datepicker/month.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<table role="grid" aria-labelledby="{{::uniqueId}}-title" aria-activedescendant="{{activeDateId}}">
<thead>
<tr>
<th><button type="button" class="btn btn-default btn-sm pull-left uib-left" ng-click="move(-1)" tabindex="0" aria-label="Previous year"><i aria-hidden="true" class="glyphicon glyphicon-chevron-left"></i><span class="sr-only">previous</span></button></th>
<th colspan="{{::yearHeaderColspan}}"><button id="{{::uniqueId}}-title" role="heading" aria-live="assertive" aria-atomic="true" type="button" class="btn btn-default btn-sm uib-title" ng-click="toggleMode()" ng-disabled="datepickerMode === maxMode" tabindex="0"><strong>{{title}}</strong></button></th>
<th><button type="button" class="btn btn-default btn-sm pull-right uib-right" ng-click="move(1)" tabindex="0" aria-label="Next year"><i aria-hidden="true" class="glyphicon glyphicon-chevron-right"></i><span class="sr-only">next</span></i></button></th>
<th><button type="button" class="btn btn-default btn-sm pull-left uib-left" ng-click="move(-1)" tabindex="0" aria-label="{{::previousYearLabel}}"><i aria-hidden="true" class="glyphicon glyphicon-chevron-left"></i><span class="sr-only">{{::previousYearLabel}}</span></button></th>
<th colspan="{{::yearHeaderColspan}}"><button id="{{::uniqueId}}-title" aria-live="assertive" aria-atomic="true" type="button" class="btn btn-default btn-sm uib-title" ng-click="toggleMode()" ng-disabled="datepickerMode === maxMode" tabindex="0"><strong>{{title}}</strong></button></th>
<th><button type="button" class="btn btn-default btn-sm pull-right uib-right" ng-click="move(1)" tabindex="0" aria-label="{{::nextYearLabel}}"><i aria-hidden="true" class="glyphicon glyphicon-chevron-right"></i><span class="sr-only">{{::nextYearLabel}}</span></button></th>
</tr>
</thead>
<tbody tabindex="0" ng-keydown="keydown($event)">
Expand Down
6 changes: 3 additions & 3 deletions template/datepicker/year.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<table role="grid" aria-labelledby="{{::uniqueId}}-title" aria-activedescendant="{{activeDateId}}">
<thead>
<tr>
<th><button type="button" class="btn btn-default btn-sm pull-left uib-left" ng-click="move(-1)" tabindex="0" aria-label="Previous years"><i aria-hidden="true" class="glyphicon glyphicon-chevron-left"></i><span class="sr-only">previous</span></button></th>
<th colspan="{{::columns - 2}}"><button id="{{::uniqueId}}-title" role="heading" aria-live="assertive" aria-atomic="true" type="button" class="btn btn-default btn-sm uib-title" ng-click="toggleMode()" ng-disabled="datepickerMode === maxMode" tabindex="0"><strong>{{title}}</strong></button></th>
<th><button type="button" class="btn btn-default btn-sm pull-right uib-right" ng-click="move(1)" tabindex="0" aria-label="Next years"><i aria-hidden="true" class="glyphicon glyphicon-chevron-right"></i><span class="sr-only">next</span></button></th>
<th><button type="button" class="btn btn-default btn-sm pull-left uib-left" ng-click="move(-1)" tabindex="0" aria-label="{{::previousYearsLabel}}"><i aria-hidden="true" class="glyphicon glyphicon-chevron-left"></i><span class="sr-only">{{::previousYearsLabel}}</span></button></th>
<th colspan="{{::columns - 2}}"><button id="{{::uniqueId}}-title" aria-live="assertive" aria-atomic="true" type="button" class="btn btn-default btn-sm uib-title" ng-click="toggleMode()" ng-disabled="datepickerMode === maxMode" tabindex="0"><strong>{{title}}</strong></button></th>
<th><button type="button" class="btn btn-default btn-sm pull-right uib-right" ng-click="move(1)" tabindex="0" aria-label="{{::nextYearsLabel}}"><i aria-hidden="true" class="glyphicon glyphicon-chevron-right"></i><span class="sr-only">{{::nextYearsLabel}}</span></button></th>
</tr>
</thead>
<tbody tabindex="0" ng-keydown="keydown($event)">
Expand Down