Skip to content

first go at this, outputs seem sensible but not tested#3

Open
benmsanderson wants to merge 1 commit into
chrisroadmap:mainfrom
benmsanderson:implement-class-wrapper
Open

first go at this, outputs seem sensible but not tested#3
benmsanderson wants to merge 1 commit into
chrisroadmap:mainfrom
benmsanderson:implement-class-wrapper

Conversation

@benmsanderson
Copy link
Copy Markdown
Contributor

Alright - moving towards a version where we can efficiently explore the parameter space and process the output, I've tried to make a slim wrapper to call the model as a class. Original model is untouched.

@benmsanderson benmsanderson marked this pull request as draft November 19, 2024 12:44
@benmsanderson benmsanderson marked this pull request as ready for review November 19, 2024 12:44
@benmsanderson benmsanderson marked this pull request as draft November 19, 2024 12:49
@benmsanderson
Copy link
Copy Markdown
Contributor Author

benmsanderson commented Nov 19, 2024

Hey @chrisroadmap - so you might want to tweak the implementation here, but I've tried to implement a class wrapper to provide easy interactive use and parameter exploration.

@chrisroadmap chrisroadmap marked this pull request as ready for review November 19, 2024 13:35
@chrisroadmap
Copy link
Copy Markdown
Owner

hey Ben - looks nice. Could you do

git checkout main
git remote add upstream git@github.com:chrisroadmap/dice2016.git
git fetch upstream
git rebase upstream main
git checkout implement-class-wrapper
git rebase main

which will pull in the couple of updates I did to the readme yesterday.

Then do git push origin implement-class-wrapper -f to force push this branch and I can merge it.

@benmsanderson benmsanderson force-pushed the implement-class-wrapper branch from af3ef72 to 0e4bb1c Compare November 19, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants