This repository was archived by the owner on Dec 6, 2019. It is now read-only.
Handle random phantomjs crashes#37
Open
SergejKasperBM wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On my machine phantomjs crashes occasionally with the message:
PhantomJS has crashed. Please read the crash reporting guide ...As the reason is sporadic and not preventable, i thought it would be nice to restart the task upon such a crash.
A general grunt-task fix at
ariya/phantomjs#12325 (comment)
helped greatly. I adjusted the task accordingly.
Works fine now. Though it would be nice to disable phantoms crash-logs beeing saved to /tmp and to catch a more specific error-code.
As this is a common issue with phantom i thought you might be interested in including this as a fix.