Initialize dmuart repository template based on dmgpio and dmclk by Copilot · Pull Request #3 · choco-technologies/dmuart

Copilot · 2026-05-28T09:53:09Z

Bootstraps the dmuart repository with the same DMOD module structure used in dmgpio and dmclk, adapted for UART.

Structure

Build system: CMakeLists.txt with DMUART_MCU_SERIES parameter, DMOD FetchContent integration, dmod_add_library usage
DMOD metadata: manifest.dmm, dmuart.dmr resource file
Types (include/dmuart_types.h): Typed enums for all configuration parameters — word length, parity, stop bit, flow control, bit order, invert, loopback, interrupt trigger; interrupt handler types and params struct
Public API (include/dmuart.h): dmuart_config_t structure with typed fields; ioctl command set for runtime configuration
Port layer (include/dmuart_port.h): Individual setters/getters for each parameter (baudrate, word_length, parity, stop_bit, bit_order, invert, loopback), interrupt trigger/handler registration, flush, transmit/receive
Core driver (src/dmuart.c): Full DMDRVI implementation — create/free/open/close/read/write/ioctl/flush/stat with dmhaman interrupt dispatch support
STM32F7 port (src/port/stm32f7/port.c): Register-level USART1-8 support with ISR handlers, all setters/getters, polled TX/RX
STM32F4 port (src/port/stm32f4/port.c): Register-level USART1-6 support with ISR handlers for the F4 family
Configs: Per-board folders with per-UART config files including GPIO pin configuration for dmdevfs auto-setup (8 boards: nucleo-f401re, nucleo-f411re, nucleo-f446re, nucleo-f767zi, stm32f4-discovery, stm32f429i-discovery, stm32f746g-disco, stm32f769i-discovery)
CI: GitHub Actions workflow with dynamic CPU family discovery and matrix build
Tests: Loopback test application using dmdrvi interface with config file path (tests/dmuart-test/)
Docs: Module overview, API reference, configuration guide, port implementation guide

Usage

[stlink_vcp]
driver_name=dmuart
baudrate=921600
databits=8
parity=none
stopbits=1
flowcontrol=none
instance=1

[stlink_vcp_tx]
driver_name=dmgpio
pin=PA9
mode=alternate
alternate_function=7
speed=maximum
output_circuit=push_pull
pull=up

[stlink_vcp_rx]
driver_name=dmgpio
pin=PB7
mode=alternate
alternate_function=7
pull=up

dmini_context_t config = dmini_load("configs/board/stm32f746g-disco/usart1.ini");
dmdrvi_dev_num_t dev_num = {0};
dmdrvi_context_t ctx = dmuart_dmdrvi_create(config, &dev_num);
void* handle = dmuart_dmdrvi_open(ctx, DMDRVI_O_RDWR);

dmuart_dmdrvi_write(ctx, handle, data, len, 0);
size_t n = dmuart_dmdrvi_read(ctx, handle, buf, sizeof(buf), 0);
dmuart_dmdrvi_flush(ctx, handle);

cmake -DDMUART_MCU_SERIES=stm32f7 -B build
cmake --build build

# or for STM32F4:
cmake -DDMUART_MCU_SERIES=stm32f4 -B build
cmake --build build

- Add CMakeLists.txt with DMOD build system integration - Add manifest.dmm and dmuart.dmr resource files - Add include/ with dmuart.h (public API) and dmuart_port.h (port layer) - Add include/port/ with STM32 register definitions - Add src/dmuart.c core DMDRVI implementation - Add src/port/ with STM32F7 UART port implementation - Add configs/ with board and MCU configuration files - Add docs/ with module, API, configuration, and port guides - Add tests/dmuart-test/ with loopback test application - Add examples/config.ini - Add .vscode/ settings and tasks - Update .gitignore and README.md

JohnAmadis

@copilot popraw to proszę

JohnAmadis · 2026-05-28T10:03:12Z

@@ -0,0 +1,9 @@
+; STM32F746G-DISCO board UART configuration


Dodaj więcej konfiguracji płytek, przynajmniej tyle samo co w dmgpio

Added board configurations for: nucleo-f401re, nucleo-f411re, nucleo-f446re, nucleo-f767zi, stm32f4-discovery, stm32f429i-discovery, stm32f746g-disco, stm32f769i-discovery — matching the same set as dmgpio.

JohnAmadis · 2026-05-28T10:03:25Z

+; STM32F746G-DISCO board UART configuration
+; Uses USART1 (connected to ST-Link virtual COM port)
+[dmuart]
+baudrate=115200


daj jakąś wyższą prędkość, ta jest za niska

Changed default baud rate to 921600 across all board and MCU configs.

JohnAmadis · 2026-05-28T10:06:45Z

@@ -0,0 +1,8 @@
+{


brakuje też konfiguracji CI dla githuba

Added .github/workflows/ci.yml with the same pattern as dmgpio — auto-discovers CPU families from src/port/*/port.c and builds each in a matrix using the chocotechnologies/dmod:1.0.4 container.

JohnAmadis · 2026-05-28T10:07:48Z

@@ -0,0 +1,325 @@
+#define DMOD_ENABLE_REGISTRATION    ON


wsparcie dla innych rodzin (przynajmniej f4) też powinno być

Added full STM32F4 port at src/port/stm32f4/port.c with register definitions in include/port/stm32f4_regs.h. Supports USART1-6 with the same API as STM32F7. CI will now build both families.

JohnAmadis · 2026-05-28T10:09:38Z

+ * 
+ * @return int 0 on success, non-zero on failure
+ */
+dmod_dmuart_port_api_declaration(1.0, int, _init, ( uint32_t instance, dmuart_baudrate_t baudrate, dmuart_databits_t databits, uint8_t parity, uint8_t stopbits, uint8_t flowcontrol) )


w dmgpio dla każdego parametru konfiguracyjnego były enumy - sprawdź sobie header dmgpio_types.h - tutaj też tak powinno być. Nie chcemy zgadywać co tam się przekazuje

Created include/dmuart_types.h with typed enums for all parameters: dmuart_word_length_t, dmuart_parity_t, dmuart_stop_bit_t, dmuart_flow_control_t, dmuart_bit_order_t, dmuart_invert_t, dmuart_loopback_t, dmuart_int_trigger_t. The port layer now uses these types in all setters/getters instead of raw uint8_t.

JohnAmadis · 2026-05-28T10:15:05Z

+        return -1;
+    }
+
+    volatile USART_TypeDef *USART = (USART_TypeDef *)uart_base_addresses[instance - 1];


a co z obsługą przerwań? Nie widzę żadnej

Added full interrupt support — DMOD_IRQ_HANDLER entries for all UART instances (both F4 and F7), set_interrupt_trigger to enable/disable specific interrupt sources (RXNE, TXE, TC, IDLE, Error), and add/remove_interrupt_handler for callback registration. ISR dispatches to registered handler with trigger type and received data.

JohnAmadis · 2026-05-28T10:27:08Z

@@ -0,0 +1,9 @@
+; STM32F746G-DISCO board UART configuration
+; Uses USART1 (connected to ST-Link virtual COM port)
+[dmuart]


pliki konfiguracyjne dla uarta powinny również zawierać konfigurację dla niezbędnych pinów w gpio - tak, aby jak ktoś zdecyduje, że chce używać uarta, to automatycznie mu się skonfiguruje też gpio odpowiednio. dmdevfs wspiera takie coś - wystarczy dodać osobną sekcję i dodać w niej klucz driver_name (sprawdz sobie dokumentację dmdevfs).

Ponadto, jako że jest tam kilka uartów różnych na płytce, to moglibyśmy zrobić tak, że stworzymy folder configs/board/stm32f746g-disco/ a wewnątrz dodamy osobne pliki z konfiguracjami na każdego dostępnego uarta na płytce

Jako nazwę sekcji użyj też jakieś human friendly nazwy tego uarta, bo dzięki temu dmdevfs stworzy odpowiedni plik o tej nazwie.

Restructured configs: each board is now a folder (e.g. configs/board/stm32f746g-disco/) with per-UART .ini files. Each file uses human-friendly section names (e.g. [stlink_vcp], [arduino_uart]) and includes GPIO pin configuration sections with driver_name=dmgpio for TX/RX pins, so dmdevfs will auto-configure both drivers.

JohnAmadis · 2026-05-28T10:29:47Z

+ */
+dmod_dmdrvi_dif_api_declaration(1.0, dmuart, int, _flush, ( dmdrvi_context_t context, void* handle ))
+{
+    return 0;


czemu flusha nie implementujesz? Też jest potrzebny

Flush is now properly implemented — calls dmuart_port_flush() which waits for TX complete and drains RX FIFO.

JohnAmadis · 2026-05-28T10:32:52Z

+    Dmod_Printf("Baud rate     : %u\n\n", baudrate);
+
+    /* Initialize UART: 8N1, no flow control */
+    int ret = dmuart_port_init(instance, baudrate, 8, 0, 0, 0);


nie powinieneś sam inicjalizować uarta do testów - lepiej jak Ci użytkownik przekażę ścieżkę do pliku z gotowym uartem

Redesigned the test — it now takes a config file path as argument and creates the UART via dmuart_dmdrvi_create() using dmini_load(). No more direct port initialization.

JohnAmadis · 2026-05-28T10:35:41Z

+    dmdrvi_context_t context = Dmod_Malloc(sizeof(struct dmdrvi_context));
+    if (context != NULL)
+    {
+        memset(context, 0, sizeof(*context));


z tego co widzę, to też nie obsługujesz kompletnie przerwań i dmhaman - powinieneś dać możliwość podania interrupt_trigger tak jak dmgpio - czyli żeby się dało triggerować handlery jak się otrzyma dane z uarta

Added dmhaman integration: the driver reads interrupt_trigger and interrupt_handler from the INI config. When configured, it registers a port interrupt handler that calls dmhaman_call_handler() with dmuart_interrupt_params_t (instance, trigger type, received data). Also available via dmuart_ioctl_cmd_set_interrupt_handler ioctl.

…CI, board configs - Add dmuart_types.h with enums for all parameters (word_length, parity, stop_bit, flow_control, bit_order, invert, loopback, interrupt_trigger) - Redesign port layer with individual setters/getters per parameter - Add interrupt support with dmhaman integration (interrupt_trigger config) - Implement flush properly via port layer - Add STM32F4 port implementation - Add GitHub CI workflow (matching dmgpio pattern) - Restructure board configs as folders with per-UART files + GPIO pin config - Increase default baud rate to 921600 - Redesign test to accept config file path via dmdrvi

Copilot · 2026-05-28T10:49:57Z

@copilot popraw to proszę

Done — addressed all review feedback in commits Address review feedback: add types, STM32F4 port, interrupts, flush, CI, board configs and Fix circular include in dmuart_port.h and clarify loopback comments.

JohnAmadis

@copilot kolejne poprawki są niezbędne

JohnAmadis · 2026-05-28T10:52:25Z

@@ -0,0 +1,70 @@
+name: CI


a release? Czemu tylko jedno skopiowałeś? Nie przyszło Ci do głowy, że drugie też jest potrzebne?

JohnAmadis · 2026-05-28T10:54:40Z

+flowcontrol=none
+instance=6
+
+[arduino_uart_tx]


wydaje mi się, że gpio piny powinny być konfigurowane jako pierwsze, bo inaczej nie będziesz mógł użyć uarta

JohnAmadis · 2026-05-28T11:10:13Z

+
+on:
+  push:
+    branches: [ master, develop ]


tutaj w repo jest branch main

JohnAmadis · 2026-05-28T11:11:54Z

+    }
+
+    const char *config_path = argv[1];
+    Dmod_Printf("Config file: %s\n\n", config_path);


nie rozumiesz - nie potrzebujesz czytać config file'a,bo już powinien być skonfigurowany przez dmdevfs - użytkownik ma ci tylko podac sciezke do pliku

JohnAmadis · 2026-05-28T11:14:39Z

+    dmuart_config_t *c = &context->config;
+    int ret;
+
+    ret = dmuart_port_init(c->instance);


dodaj jeszcze kontrolę zajętości kanału - tak, żeby przed skonfigurowaniem najpierw driver spróbował oznaczyć go sobie jako "zajęty" - tak aby następnym razem jak ktoś próbuje jeszcze raz użyć tego samego kanału i skonfigurować go do czegoś innego, żeby dostał błąd "channel is already used"

JohnAmadis · 2026-05-28T11:17:44Z

+{
+    if (validate_instance(instance) != 0 || data == NULL || received == NULL) return -1;
+
+    volatile USART_TypeDef *USART = get_usart(instance);


te Twoje nazwy typów USART_TypeDef aż biją po oczach biblioteką stm32 cube - dopasuj nazewnictwo do lokalnego standardu kodowania - snake_case, z suffixem _t dla typów

JohnAmadis · 2026-05-28T11:20:22Z

+            return -1;
+        }
+
+        data[i] = (uint8_t)(USART->RDR & 0xFF);


a gdzie jakiś lokalny bufor? Z przerwania, jak tylko przyjdą dane, powinieneś je wrzucać do lokalnego bufora, np cycle ring. I jak ktoś zawoła receive to z niego to odczytywać... Nie powinniśmy tracić żadnych danych - a tymczasem w twoim rozwiazaniu jak nie zdazymy czegos odebrac to to przepada.

Możesz sobie zobaczyć jak ja to zaimplementowałem w innym systemie:
https://bitbucket.org/chocos/chocos/src/develop/Source/system/portable/src/st/stm32f7/lld/uart/oc_uart_lld.c

oc_uart_lld.c

JohnAmadis · 2026-05-28T11:27:17Z

+    return received;
+}
+
+dmod_dmdrvi_dif_api_declaration(1.0, dmuart, size_t, _write, ( dmdrvi_context_t context, void* handle, const void* buffer, size_t size, uint32_t offset ))


dodaj jakieś komentarze doxygen do tych wszystkich funkcji bo pusto jest jakoś tak.

I najlepiej też jakiś komentarz separacyjny w stylu:

// ========================================================================== /** * @brief moja znakomita funkcja * ... */ // ==========================================================================

Agent-Logs-Url: https://github.com/choco-technologies/dmuart/sessions/5539024c-7c56-46f0-9c15-d5625929e3ee

JohnAmadis · 2026-05-28T12:10:12Z

@copilot nie buduje Ci sie projekt:

[ 68%] Building C object src/port/CMakeFiles/dmuart_port.dir/stm32f4/port.c.o
/__w/dmuart/dmuart/src/port/stm32f4/port.c: In function 'dmod_init':
/__w/dmuart/dmuart/src/port/stm32f4/port.c:82:5: warning: implicit declaration of function 'Dmod_Printf' [-Wimplicit-function-declaration]
82 | Dmod_Printf("DMUART port module initialized (STM32F4)\n");
| ^~~~~~~~~~~
[ 75%] Building C object src/port/CMakeFiles/dmuart_port.dir/dmuart_port_header.c.o
[ 81%] Linking C executable dmuart_port
/tools/arm-gnu-toolchain/bin/../lib/gcc/arm-none-eabi/13.3.1/../../../../arm-none-eabi/bin/ld: CMakeFiles/dmuart_port.dir/stm32f4/port.c.o: in function dmod_init': port.c:(.text.dmod_init+0x6): undefined reference to Dmod_Printf'
/tools/arm-gnu-toolchain/bin/../lib/gcc/arm-none-eabi/13.3.1/../../../../arm-none-eabi/bin/ld: CMakeFiles/dmuart_port.dir/stm32f4/port.c.o: in function dmod_deinit': port.c:(.text.dmod_deinit+0x6): undefined reference to Dmod_Printf'
collect2: error: ld returned 1 exit status
make[2]: *** [src/port/CMakeFiles/dmuart_port.dir/build.make:120: src/port/dmuart_port] Error 1
make[1]: *** [CMakeFiles/Makefile2:589: src/port/CMakeFiles/dmuart_port.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

… STM32F4 and STM32F7 port implementations

Initial plan

21a5abb

Copilot AI assigned Copilot and JohnAmadis May 28, 2026

Copilot started work on behalf of JohnAmadis May 28, 2026 09:53 View session

Copilot AI linked an issue May 28, 2026 that may be closed by this pull request

Przygotować szablon repozytorium bazując na dmgpio i dmclk #2

Closed

Copilot AI added 2 commits May 28, 2026 10:00

Address review feedback: fix comments in port.c and dmuart.c

735d9db

Copilot AI changed the title ~~[WIP] Prepare repository template based on dmgpio and dmclk~~ Initialize dmuart repository template based on dmgpio and dmclk May 28, 2026

Copilot AI requested a review from JohnAmadis May 28, 2026 10:02

Copilot finished work on behalf of JohnAmadis May 28, 2026 10:02

JohnAmadis requested changes May 28, 2026

View reviewed changes

Copilot started work on behalf of JohnAmadis May 28, 2026 10:36 View session

Copilot AI added 2 commits May 28, 2026 10:47

Fix circular include in dmuart_port.h and clarify loopback comments

599c2ea

Copilot finished work on behalf of JohnAmadis May 28, 2026 10:50

Copilot AI requested a review from JohnAmadis May 28, 2026 10:50

JohnAmadis requested changes May 28, 2026

View reviewed changes

Copilot started work on behalf of JohnAmadis May 28, 2026 11:27 View session

Changes before error encountered

9b366ca

Agent-Logs-Url: https://github.com/choco-technologies/dmuart/sessions/5539024c-7c56-46f0-9c15-d5625929e3ee

Copilot stopped work on behalf of JohnAmadis due to an error May 28, 2026 11:32
You've hit your rate limit. Please wait for your limit to reset in 1 hour 35 minutes or switch to auto model to continue. Learn More (https://docs.github.com/copilot/concepts/rate-limits). (Request ID...

Copilot AI requested a review from JohnAmadis May 28, 2026 11:32

Copilot started work on behalf of JohnAmadis May 28, 2026 11:44 View session

Copilot stopped work on behalf of JohnAmadis due to an error May 28, 2026 11:46
You've hit your rate limit. Please wait for your limit to reset in 1 hour 21 minutes or switch to auto model to continue. Learn More (https://docs.github.com/copilot/concepts/rate-limits). (Request ID...

Copilot started work on behalf of JohnAmadis May 28, 2026 12:10 View session

Copilot stopped work on behalf of JohnAmadis due to an error May 28, 2026 12:12
You've hit your rate limit. Please wait for your limit to reset in 55 minutes or switch to auto model to continue. Learn More (https://docs.github.com/copilot/concepts/rate-limits). (Request ID: 505A:...

Remove test subdirectory and associated test files; include dmod.h in…

1dbb9d5

… STM32F4 and STM32F7 port implementations

JohnAmadis marked this pull request as ready for review May 28, 2026 12:41

JohnAmadis merged commit c8ab0c2 into main May 28, 2026
3 checks passed

Conversation

Copilot AI commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Structure

Usage

Uh oh!

JohnAmadis left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 28, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 28, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 28, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 28, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 28, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 28, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 28, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 28, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 28, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented May 28, 2026

Uh oh!

JohnAmadis left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented May 28, 2026 •

edited

Loading