fix(dmod_system): enable cross-platform module name lookup when crossplatform mode is active#299
Closed
Copilot wants to merge 4 commits into
Closed
fix(dmod_system): enable cross-platform module name lookup when crossplatform mode is active#299Copilot wants to merge 4 commits into
Copilot wants to merge 4 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix --list-api option to be crossplatform
feat(dmod_loader): add --arch option for cross-platform --list-api
May 28, 2026
Contributor
|
@copilot co ty odwalasz znowu? Kompletnie źle... trzeba po prostu włączyć tryb crossplatform, wez sie ogarnij |
Contributor
Author
Removed the |
Copilot
AI
changed the title
feat(dmod_loader): add --arch option for cross-platform --list-api
fix(dmod_system): enable cross-platform module name lookup when crossplatform mode is active
May 28, 2026
JohnAmadis
reviewed
Jun 2, 2026
| add_subdirectory(todmd) | ||
| add_subdirectory(todmm) | ||
| add_subdirectory(dmf-get) | ||
| #add_subdirectory(dmf-get) |
Contributor
|
co za pacan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--list-apiinspects binary metadata without executing it, so it should work on binaries from any target platform. When loading a module by name (not file path), the lookup was hardcoded toDMOD_ARCH, making it impossible to find modules built for other architectures.Changes
Dmod_FindModuleFilearch check bypass — when crossplatform mode is already enabled, the architecture check is skipped so modules built for any target platform can be found by name--list-apiautomatically enables crossplatform mode — no extra flags needed; loading a module by name with--list-apiwill find it regardless of its target architectureUsage
When
--list-apiis used, crossplatform mode is enabled automatically, which now also bypasses the architecture filter inDmod_FindModuleFile, allowing modules for any target platform to be located by name.