Skip to content

[WIP] Add support for modules path in Dmod_LoadFile#191

Merged
JohnAmadis merged 3 commits intodevelopfrom
copilot/add-module-support-path
Dec 28, 2025
Merged

[WIP] Add support for modules path in Dmod_LoadFile#191
JohnAmadis merged 3 commits intodevelopfrom
copilot/add-module-support-path

Conversation

Copy link
Contributor

Copilot AI commented Dec 28, 2025 •
edited
Loading

Plan: Add support for [package]/module path format in Dmod_LoadFile

  • Understand the existing codebase structure and locate relevant functions
  • Analyze how Dmod_ReadNextModule returns paths in [package]/module format
  • Implement path parsing in Dmod_LoadFile to detect [package_name]/module_name format
  • Add logic to extract package name and module name from the path
  • Call Dmod_LoadFromPackage when the path format is detected
  • Ensure backward compatibility with existing file path behavior
  • Build and test the changes (all 22 tests pass including 5 new tests)
  • Add comprehensive tests to verify the new functionality
  • Fix related bug in Dmod_Pck_FindSlotByName for NULL safety
  • Run security checks
  • Request code review
Original prompt

This section details on the original issue you should resolve

<issue_title>Dodać wsparcie [modules] w ścieżce dla Dmod_LoadFile</issue_title>
<issue_description>Jeśli plik Path nie istnieje i jako ścieżka do modułu jest podane [nazwa_paczki]/nazwa_modułu, to funkcja powinna spróbować załadować moduł z podanej paczki, aby być kompatybilną z Dmod_ReadRequiredModules oraz Dmod_ReadNextModule, które to zwracają jako path modułu nazwę paczki w formacie:
[paczka]/modul
</issue_description>

Comments on the Issue (you are @copilot in this section)

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI self-assigned this Dec 28, 2025
@JohnAmadis
Add [package]/module path support to Dmod_LoadFile
611f739 
Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
@JohnAmadis JohnAmadis marked this pull request as ready for review December 28, 2025 17:17
@JohnAmadis
Add tests and fix bug in Dmod_Pck_FindSlotByName
864dca8 
- Add comprehensive tests for [package]/module path support
- Fix bug in Dmod_Pck_FindSlotByName where NULL package names caused segfault
- All 22 tests passing

Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
@JohnAmadis JohnAmadis merged commit f68c587 into develop Dec 28, 2025
4 checks passed
Copilot AI requested a review from JohnAmadis December 28, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JohnAmadis JohnAmadis Awaiting requested review from JohnAmadis

Assignees

@JohnAmadis JohnAmadis

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dodać wsparcie [modules] w ścieżce dla Dmod_LoadFile

2 participants

@JohnAmadis