Add dmffs config directory mounting at /configs/#50
Merged
JohnAmadis merged 3 commits intomasterfrom Dec 29, 2025
Merged
Conversation
Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add mounting of configuration directory using dmffs
Add dmffs config directory mounting at /configs/
Dec 29, 2025
JohnAmadis
requested changes
Dec 29, 2025
Contributor
JohnAmadis
left a comment
There was a problem hiding this comment.
@copilot zapisz to sobie gdzies w instrukcjach na przyszłość - nie używamy snprintf tylko funkcji z DMOD SAL
src/main.c
Outdated
| @@ -1,5 +1,6 @@ | |||
| #define DMOD_ENABLE_REGISTRATION | |||
| #include <string.h> | |||
| #include <stdio.h> | |||
Contributor
There was a problem hiding this comment.
żadnego stdio!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
Contributor
Author
There was a problem hiding this comment.
Fixed in 9716f7d - removed stdio.h include
src/main.c
Outdated
|
|
||
| // Mount the dmffs filesystem at /configs/ | ||
| char mount_opts[128]; | ||
| snprintf(mount_opts, sizeof(mount_opts), "addr=0x%X,size=%u", |
Contributor
Author
There was a problem hiding this comment.
Fixed in 9716f7d - replaced snprintf with Dmod_SnPrintf
Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
Contributor
Author
Understood - will use DMOD SAL functions (like Dmod_SnPrintf) instead of standard C library functions going forward |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan: Add Configuration Directory Mounting with dmffs
Understanding:
/configs/Implementation Steps:
scripts/romfs.cmakescript to:DMBOOT_CONFIG_DIRcmake variablemake_dmffstool to create filesystem image from the config directoryCMakeLists.txtto:DMBOOT_CONFIG_DIRas a cmake cache variablesrc/main.cto:/configs/inmount_embedded_filesystems()Summary
Successfully implemented configuration directory mounting using dmffs with DMOD SAL functions.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.