Fix DMOD_ENABLE_REGISTRATION multiple definition linker errors#46
Closed
Fix DMOD_ENABLE_REGISTRATION multiple definition linker errors#46
Conversation
- Modified dmlist.c to use DMOD_EXTERNAL_REGISTRATION guard - Uncommented DMOD_ENABLE_REGISTRATION in main.c When DMOD_EXTERNAL_REGISTRATION is defined (as in dmboot), dmlist.c will not define DMOD_ENABLE_REGISTRATION, avoiding multiple definition errors. Registration is handled by main.c instead. Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
- Pass DMOD_EXTERNAL_REGISTRATION compile definition to dmlist target - Update dmlist submodule with guard to prevent multiple registrations This enables main.c to handle all registrations when DMOD_ENABLE_REGISTRATION is defined, avoiding multiple definition linker errors. Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix linking issue with DMOD_ENABLE_REGISTRATION
Fix DMOD_ENABLE_REGISTRATION multiple definition linker errors
Nov 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uncommenting
DMOD_ENABLE_REGISTRATIONinmain.ccaused multiple definition linker errors. The root cause:dmlist.cunconditionally definedDMOD_ENABLE_REGISTRATION, creating duplicate registration structs whenmain.calso defined it before includingdmlist.h.Changes
lib/dmlist/src/dmlist.c: Apply same guard pattern asdmod_system.c:lib/CMakeLists.txt: PassDMOD_EXTERNAL_REGISTRATIONcompile definition to dmlist target when enabledsrc/main.c: UncommentDMOD_ENABLE_REGISTRATIONto enable the featureNote
The dmlist submodule commit needs to be pushed upstream to
choco-technologies/dmlistbefore CI will pass.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.