catini: fix file truncation by replacing FileReadLine with FileRead-based line assembly#49
Open
Copilot wants to merge 3 commits into
Open
catini: fix file truncation by replacing FileReadLine with FileRead-based line assembly#49Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix incorrect file display in catini
catini: fix file truncation by replacing FileReadLine with FileRead-based line assembly
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
catiniwas silently truncating INI files mid-read on the STM32 target because the embedded FS'sFileReadLine(fgets-like) returnsNULLprematurely.catusesFileRead(fread-like) and displays files correctly.Changes
commands/catini/catini.cDmod_FileReadLineloop with aDmod_FileReadchunk-loop that manually assembles lines, adding a second heap-allocated read buffer (256 B) — mirrors the proven pattern incat.c\rcharacters to correctly handle\r\nline endingsprint_highlighted_linewithout trailing\n; every branch now appends\nafterVT100_RESET, so the reset escape always precedes the newline instead of appearing at the start of the next line