Skip to content

Conversation

@ccall48
Copy link
Contributor

@ccall48 ccall48 commented Jan 9, 2026

added in digital matter oyster3 & yabby3 lorawan devices and decoders.

added in new sensecap t2000 tracker and decoder and some additional sensecap devices and decoders.

@brocaar
Copy link
Contributor

brocaar commented Jan 12, 2026

Thanks @ccall48, I think you forgot to add the devices to the digital-matter vendor? (the devices = [] is empty in the vendor.toml).

Maybe I should change this at my side, e.g. just remove adding devices to a vendor. There is not really an use-case I see where you would add the device toml, but not assign the device to the vendor. And then just iterate over all device toml configs instead.

@brocaar brocaar merged commit 3d920dd into chirpstack:master Jan 12, 2026
2 checks passed
@ccall48
Copy link
Contributor Author

ccall48 commented Jan 12, 2026

Up to you boss, it wont matter if they're not class b or c compatible and the device is not?

I did those under the last commit before the update. thought i copied it all over before committing my bad 😅

@brocaar
Copy link
Contributor

brocaar commented Jan 13, 2026

This is has not really anything to do with Class-B / Class-C. It is more about the "discovery" of devices. E.g. the importer reads the vendor.toml, then takes the devices key from that config, to iterate over the .../devices/DEVICE.toml file. Instead, the importer could just iterate over the files in .../devices/. This is less error prone :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants