Use require instead of Builder.error for Mux size mismatch#5311
Open
kimjune01 wants to merge 1 commit into
Open
Use require instead of Builder.error for Mux size mismatch#5311kimjune01 wants to merge 1 commit into
kimjune01 wants to merge 1 commit into
Conversation
Change from Builder.error to require for size mismatch validation. Builder.error allows execution to continue, causing silent data loss when zip truncates the longer sequence. With require, the error is caught immediately preventing incorrect circuit generation. Fixes chipsalliance#4444 where PriorityMux(Seq(a, b), Seq(foo, bar, fizz)) would silently drop fizz instead of failing fast. Updated tests to expect IllegalArgumentException instead of ChiselException since require throws immediately rather than collecting errors for later batch reporting.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mux1HandPriorityMuxfromBuilder.errortorequirefor mismatched sequence sizes, so the error is thrown immediately instead of deferredBuilder.errorallowed execution to continue, causingzipto silently truncate the longer sequence and produce incorrect circuitsIllegalArgumentExceptioninstead ofChiselException, add regression test for PriorityMux drops arguments if input sequences are not the same size #4444Test plan
Mux1HandPriorityMuxto verifyIllegalArgumentExceptionis thrownPriorityMux(Seq(a, b), Seq(foo, bar, fizz))now fails fast instead of silently droppingfizz