Draft
Conversation
Contributor
Author
|
I'm going to just debump Mill for now and put this on the Chisel 8 Tracker. |
Member
|
FWIW, I'm good with dropping support for < 2.13.9. I'm not sure who would truly object to this? |
Contributor
Author
Probably no one, but it's pretty easy to revert my Mill bump from last week and then just do this as soon as we decide to start Chisel 8 work on main, even if that's literally tomorrow it's all easy enough. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Older versions of Scala do not work with newer versions of the JVM, but Scala 3.8 requires Java 17+. In the interest of simplicity, this PR drops Scala <= 2.13.8. We could make this work by splitting the build but I don't think that effort is worth it unless we have a very compelling reason.
I'm also inclined to just do this on a minor version of our own (I doubt anyone is still on that old of Scala and they should be able to bump easily) unless we want to hard break main towards Chisel 8.
Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
Users of older Scala minor versions are always advised to upgrade to the newest minor version within their major version.
If this is a problem for any users, please reach out to us on Github.
Reviewer Checklist (only modified by reviewer)
3.6.x,5.x, or6.xdepending on impact, API modification or big change:7.0)?Enable auto-merge (squash)and clean up the commit message.Create a merge commit.