Remove deprecated BoringUtils API and Source/Sink annotations.#5137
Open
dtzSiFive wants to merge 1 commit intochipsalliance:mainfrom
Open
Remove deprecated BoringUtils API and Source/Sink annotations.#5137dtzSiFive wants to merge 1 commit intochipsalliance:mainfrom
dtzSiFive wants to merge 1 commit intochipsalliance:mainfrom
Conversation
Member
Author
|
Draft until some uses elsewhere are confirmed removed. Presumably features marked for hard removal are not those there is an expectation of binary compatibility for? Anyway, just looking to clean things up and inspired by seeing deprecation warnings in our builds. cc @jackkoenig -- how do you like this handled (these were deprecated in 6.0.0, and marked for removal in 7.0)? |
seldridge
added a commit
to llvm/circt
that referenced
this pull request
Jan 8, 2026
Drop support for "legacy" wiring problems which are those indicated by the long-deprecated and finally removed `SourceAnnotation` and `SinkAnnotation` [[1]]. [1]: chipsalliance/chisel#5137 Co-authored-by: Will Dietz <will.dietz@sifive.com> Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
Remove deprecated
BoringUtils.addSourceandBoringUtils.addSinkAPIs.Reviewer Checklist (only modified by reviewer)
3.6.x,5.x, or6.xdepending on impact, API modification or big change:7.0)?Enable auto-merge (squash)and clean up the commit message.Create a merge commit.