net_helper: fix function comment accuracy and VLAN break condition bug#30
Draft
net_helper: fix function comment accuracy and VLAN break condition bug#30
Conversation
Agent-Logs-Url: https://github.com/chipitsine/haproxy/sessions/61b89227-9066-41da-abb3-df8847d40fd0 Co-authored-by: chipitsine <2217296+chipitsine@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Check relevance of function comments
net_helper: fix function comment accuracy and VLAN break condition bug
Mar 30, 2026
Agent-Logs-Url: https://github.com/chipitsine/haproxy/sessions/88ece909-29e2-464c-8519-28e4ae89c509 Co-authored-by: chipitsine <2217296+chipitsine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests/unit/test-eth-vlan.c— standalone C unit test forsample_conv_eth_vlanexercising no-VLAN, single-VLAN, double-VLAN, truncated-header and regression casestests/unit/test-eth-vlan.sh— shell wrapper following HAProxy unit test conventionsidx + 4 < datais used