Fix UTF-8 boundary handling in message splitting#18
Merged
Conversation
`split_message` computed chunk end positions as byte offsets, then sliced the string directly. Multi-byte UTF-8 characters (e.g. CJK) caused a panic when the byte boundary fell inside a character. Walk `end` back to the nearest valid UTF-8 char boundary before slicing, so strings containing non-ASCII text are handled safely. https://claude.ai/code/session_01MHwScetduzBSN7R1huNoN6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed a potential panic in the
split_messagefunction when splitting text at invalid UTF-8 character boundaries.Key Changes
panicerrors that could occur when attempting to slice at invalid UTF-8 positionsImplementation Details
The fix adds a safety check that iterates backwards from the calculated end position until a valid UTF-8 character boundary is found (verified via
text.is_char_boundary(end)). This ensures that all subsequent string slicing operations work correctly, even when processing text with multi-byte UTF-8 characters.https://claude.ai/code/session_01MHwScetduzBSN7R1huNoN6