Skip to content

Conversation

@kanru
Copy link
Member

@kanru kanru commented Dec 30, 2025

See also #790 (comment)

Thanks to @ShikiSuen

@kanru kanru added this to the v0.11.0 milestone Dec 30, 2025
@codecov
Copy link

codecov bot commented Dec 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.06%. Comparing base (999ee00) to head (036d4c3).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #793   +/-   ##
=======================================
  Coverage   92.06%   92.06%           
=======================================
  Files          37       37           
  Lines        9253     9253           
=======================================
  Hits         8519     8519           
  Misses        734      734           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@ShikiSuen ShikiSuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to add this Provide libchewing as a Swift package with the exposures of C_based APIs only. instead. This ensures that no one expects Swiftified APIs from this package (which brings extra burden to this repo). If anyone wants Swiftified APIs, he / she can make them by himself / herself.

NEWS Outdated
- New boolean config option `chewing.sort_candidates_by_frequency` can be
set to enable sorting candidates by frequency.
- Rust type SyllableSlice is removed from public interfaces.
- Provide libchewing as a Swift package.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Provide libchewing as a Swift package with the exposures of C_based APIs only.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense. For me libchewing refers only to the C API but your edit makes it more clear for people unfamiliar with the history of libchewing.

@kanru kanru force-pushed the push-lvzutovlsnnl branch from 0e68b76 to 036d4c3 Compare December 30, 2025 15:15
@kanru kanru merged commit 036d4c3 into master Dec 30, 2025
11 checks passed
@kanru kanru deleted the push-lvzutovlsnnl branch December 30, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants