-
Notifications
You must be signed in to change notification settings - Fork 54
fix openssl CRL error #406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
mixlib-install.gemspec
Outdated
| # Ruby 3.0-3.2 bundled openssl needs update to 3.1.2+ | ||
| # Ruby 3.3 bundled openssl needs update to 3.2.2+ | ||
| # Ruby 3.4 bundled openssl needs update to 3.3.1+ | ||
| if RUBY_VERSION < "2.7.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gemspecs don't work like this. They get interpreted and turned into JSON so this only really parses the deps based on the system where the gemspec is uploaded
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, these have to go into the Gemfile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK I was running out the door when I wrote that as was being very dumb.
Gemfile of course also will not work.
After much discussion with @Stromweld I think the only way to continue to support old versions of ruby that Mac's still have, is to branch this per ruby era, and have different major-versions of mixlib-install per ruby era.
This will get simpler as Mac is the only real reason we have to support ancient Rubies, and they're going to be dropping Ruby altogether, and then as older versions of Mac get EOLd, which happens pretty frequently, we can stop caring.
So I'm thinking something like:
- keep 3.x as ruby < 2.7
- branch a 4.x for ruby >=2.7, < 3.3
- branch a 5.x for ruby >=3.3, < 3.4
- branch a 6.x for ruby >=3.4, < 4.0
- main becomes 7.x for 4.0+
So Order of operations here is something like:
- adapt Ci to move all stuff to GHA instead of BK
- branch and lock versions
- fix openssl on each branch
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
135ecae to
128e634
Compare
Signed-off-by: Stromweld <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
|



Description
Bundled version of ruby has a known CRL check issue. latest releases of openssl gem have this fixed.
Also added GHA workflows and proper linting/unit/integration tests with supporting configuration files for the new jobs
Types of changes
Checklist:
Gemfile.lockhas changed, I have used--conservativeto do it and included the full output in the Description above.