Skip to content

Conversation

@Stromweld
Copy link

@Stromweld Stromweld commented Dec 22, 2025

Description

Bundled version of ruby has a known CRL check issue. latest releases of openssl gem have this fixed.

Also added GHA workflows and proper linting/unit/integration tests with supporting configuration files for the new jobs

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@Stromweld Stromweld requested review from a team and jaymzh as code owners December 22, 2025 21:04
@Stromweld Stromweld added the Expeditor: Bump Version Minor Used by github.minor_bump_labels to bump the Minor version number. label Dec 22, 2025
@Stromweld Stromweld self-assigned this Dec 22, 2025
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@Stromweld Stromweld requested a review from a team as a code owner December 22, 2025 21:15
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@Stromweld Stromweld requested a review from a team as a code owner December 24, 2025 03:08
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
# Ruby 3.0-3.2 bundled openssl needs update to 3.1.2+
# Ruby 3.3 bundled openssl needs update to 3.2.2+
# Ruby 3.4 bundled openssl needs update to 3.3.1+
if RUBY_VERSION < "2.7.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gemspecs don't work like this. They get interpreted and turned into JSON so this only really parses the deps based on the system where the gemspec is uploaded

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, these have to go into the Gemfile.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I was running out the door when I wrote that as was being very dumb.

Gemfile of course also will not work.

After much discussion with @Stromweld I think the only way to continue to support old versions of ruby that Mac's still have, is to branch this per ruby era, and have different major-versions of mixlib-install per ruby era.

This will get simpler as Mac is the only real reason we have to support ancient Rubies, and they're going to be dropping Ruby altogether, and then as older versions of Mac get EOLd, which happens pretty frequently, we can stop caring.

So I'm thinking something like:

  • keep 3.x as ruby < 2.7
  • branch a 4.x for ruby >=2.7, < 3.3
  • branch a 5.x for ruby >=3.3, < 3.4
  • branch a 6.x for ruby >=3.4, < 4.0
  • main becomes 7.x for 4.0+

So Order of operations here is something like:

  • adapt Ci to move all stuff to GHA instead of BK
  • branch and lock versions
  • fix openssl on each branch

Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@Stromweld Stromweld force-pushed the fix-openssl-CRL-error branch from 135ecae to 128e634 Compare December 30, 2025 18:49
Signed-off-by: Stromweld <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 2, 2026

@Stromweld Stromweld marked this pull request as draft January 2, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Expeditor: Bump Version Minor Used by github.minor_bump_labels to bump the Minor version number.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants