Issue #416: test should be updated to reuse inlined to input violation messages#418
Open
Brijeshthummar02 wants to merge 1 commit into
Open
Issue #416: test should be updated to reuse inlined to input violation messages#418Brijeshthummar02 wants to merge 1 commit into
Brijeshthummar02 wants to merge 1 commit into
Conversation
…t violation messages
Brijeshthummar02
force-pushed
the
inlinetest
branch
from
0afa9fa to
2698f0a
Compare
Member
this is a goal. |
Member
|
we can upgrade tests step by step to avoid huge PRs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #416
I updated
AbstractPatchFilterEvaluationTestto support inline violation messages from input files, while keeping backward compatibility with existingexpected.txtfiles.Before proceeding further, should this issue also include migration of existing test input bundles to inline violation comments and removal of corresponding
expected.txtfiles, or is the framework-level support sufficient for this PR?