Issue #335: Checks under neverSuppressedChecks group should give more…#381
Open
Brijeshthummar02 wants to merge 1 commit intocheckstyle:masterfrom
Open
Issue #335: Checks under neverSuppressedChecks group should give more…#381Brijeshthummar02 wants to merge 1 commit intocheckstyle:masterfrom
Brijeshthummar02 wants to merge 1 commit intocheckstyle:masterfrom
Conversation
… give more precise violations
Author
|
@romani need your review on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #335
Refines
neverSuppressedCheckshandling so violations are more precisely tied to patch-caused changes instead of always showing all violations in touched files.Changes
SuppressionPatchFilterElementto use causality-aware matching for never-suppressed checks.newlinewhere causal attribution is ambiguous).UniqueProperties(non-newline)RegexpMultiline(non-newline)JavaPatchFilterElementto makeCovariantEqualsmore precise under non-newlinestrategies.strategyintoSuppressionPatchFilterElementfromSuppressionPatchFilter.CovariantEqualspatchedline tests.