Issue #367: Tests failed on non-English Windows#380
Open
Brijeshthummar02 wants to merge 1 commit intocheckstyle:masterfrom
Open
Issue #367: Tests failed on non-English Windows#380Brijeshthummar02 wants to merge 1 commit intocheckstyle:masterfrom
Brijeshthummar02 wants to merge 1 commit intocheckstyle:masterfrom
Conversation
Contributor
Author
|
@romani ping |
romani
requested changes
Mar 29, 2026
| testConfigWithEnglishLocale(configPath); | ||
| } | ||
| finally { | ||
| Locale.setDefault(defaultLocale); |
Member
There was a problem hiding this comment.
please sentup ENGLISH locale of locale of test execution for all, at the beging, find how it was done checkstyle project.
Contributor
|
@Brijeshthummar02 can i take up the issue. |
Contributor
Author
I am working on it. |
Brijeshthummar02
force-pushed
the
testsfailed
branch
from
7be564b to
e6f396c
Compare
Member
Contributor
Author
Gotcha!! |
Brijeshthummar02
force-pushed
the
testsfailed
branch
from
e6f396c to
e68e5c0
Compare
Contributor
Author
|
Done, updated this as requested. I set English locale once for all tests at execution start (not inside each test), using It’s applied globally via JUnit extension auto-detection ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #367