Conversation
There was a problem hiding this comment.
Pull request overview
Updates the VS Code hover text shown for CODEOWNERS patterns to distinguish non-absolute patterns from exact path matches, and documents the change in the changelog.
Changes:
- Simplify hover helper text to “Substring pattern match” vs “Matches path exactly”.
- Add a 4.2.0 changelog entry describing the hover text adjustment.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/codeowners-hover-provider.ts |
Updates hover description logic for CODEOWNERS path tokens. |
CHANGELOG.md |
Adds a new release entry documenting the hover text change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
src/codeowners-hover-provider.ts
Outdated
| x, | ||
| isPattern | ||
| ? "Matches all files with same name" | ||
| : isDirectory | ||
| ? `Matches all files in directory and subdirectories` | ||
| : `Matches path exactly`, | ||
| isPattern ? "Substring pattern match" : `Matches path exactly`, | ||
| ], |
|
|
||
| ### Changed | ||
|
|
||
| - Adjust hover text for substring vs full path matches (#). |
There was a problem hiding this comment.
Pull request overview
Updates the VS Code hover tooltip for CODEOWNERS path patterns to better explain how patterns match, and publishes a new extension release.
Changes:
- Simplify hover behavior by removing filesystem checks and generating hover text from pattern syntax (leading
/, trailing/, trailing/*). - Bump extension version to 4.2.0.
- Add 4.2.0 changelog entry.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/codeowners-hover-provider.ts | Reworks hover text generation for CODEOWNERS patterns; removes fs/path-based directory probing. |
| package.json | Version bump to 4.2.0. |
| CHANGELOG.md | Adds release notes for 4.2.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| const lines: string[] = [] | ||
|
|
||
| if (hasLeadingSlash) { | ||
| lines.push("**Anchored to repo root** — only matches at the top level") |
| lines.push("**Anchored to repo root** — only matches at the top level") | ||
| } else { | ||
| lines.push( | ||
| "**Matches at any depth** — applies to this path anywhere in the repository)", |
|
|
||
| ### Changed | ||
|
|
||
| - Adjust hover text for substring vs full path matches (#). |
No description provided.