Fix fluentd mod up error by explicitly specifying Docker Hub host #3928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add explicit host configuration for Docker Hub registry to work around a potential bug in mod tool where the registry URL was being constructed without the protocol scheme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
host: registry.hub.docker.comconfiguration to fluentd'svariant.modfileBackground
The mod update workflow was failing with the following error:
The error indicates that the URL was missing the
https://registry.hub.docker.comprefix and only had the path portion.Root Cause Analysis
Investigation of the mod tool source code revealed that while the
hostfield has a default value ofregistry.hub.docker.com, there may be a code path where the URL is not properly constructed.By explicitly specifying the host in the configuration, we ensure the correct registry URL is used.