Skip to content

test: investigate deltachat 2.50 ci regressions#19

Merged
ccclxxiii merged 2 commits into
mainfrom
ccclxxiii/ci-failure-investigation
May 28, 2026
Merged

test: investigate deltachat 2.50 ci regressions#19
ccclxxiii merged 2 commits into
mainfrom
ccclxxiii/ci-failure-investigation

Conversation

@ccclxxiii
Copy link
Copy Markdown
Contributor

@ccclxxiii ccclxxiii commented May 28, 2026

summary

this updates the bundled relay_minitest test setup to remove usage of the unsupported deltachat config key:

account.set_config("delete_server_after", "10")

deltachat rpc/server 2.50.0 now rejects this key with:

unknown key "delete_server_after": matching variant not found

which causes test-mini account setup to fail before the actual relay tests run.

the same obsolete config also exists in the upstream chatmail/relay cmdeploy test suite, where it causes similar failures during test-cmdeploy runs.

this change only addresses the cmlxc side (src/relay_minitest/support.py) so that the bundled minitest suite remains compatible with deltachat 2.50.0 while upstream relay-side fixes are handled separately.

notes

  • the original purpose of delete_server_after is currently unclear
  • deltachat core maintainers indicated the setting is no longer supported
  • this pr intentionally removes the unsupported config instead of attempting to replace it with another behavior-changing setting
  • further relay-side investigation is still ongoing for test_hide_senders_ip_address

ci status

this pr may still show failing ci because test-cmdeploy uses the upstream chatmail/relay cmdeploy test suite, which has its own copy of the same unsupported config in cmdeploy/src/cmdeploy/tests/plugin.py.

that failure is outside the cmlxc source tree and needs a matching relay-side change. the intended validation for this pr is that the bundled test-mini path no longer fails from src/relay_minitest/support.py.

@ccclxxiii ccclxxiii marked this pull request as ready for review May 28, 2026 13:46
@ccclxxiii ccclxxiii requested review from hpk42, j4n, link2xt and missytake May 28, 2026 13:49
Copy link
Copy Markdown
Contributor

@missytake missytake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like the likely culprit.

@ccclxxiii ccclxxiii merged commit b7c0a1f into main May 28, 2026
1 check failed
@ccclxxiii ccclxxiii deleted the ccclxxiii/ci-failure-investigation branch May 28, 2026 13:58
@link2xt
Copy link
Copy Markdown

link2xt commented May 28, 2026

Does this work? Now messages will be deleted immediately.

@link2xt
Copy link
Copy Markdown

link2xt commented May 28, 2026

I would rather pin the core first and then figure out what the problem is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants