This repository was archived by the owner on Dec 1, 2022. It is now read-only.
Adding support for autoscaling based on a table tag as well as custom per-table config.#59
Open
CSilivestru wants to merge 7 commits intochannl:masterfrom
Open
Adding support for autoscaling based on a table tag as well as custom per-table config.#59CSilivestru wants to merge 7 commits intochannl:masterfrom
CSilivestru wants to merge 7 commits intochannl:masterfrom
Conversation
We can afford the extra 20c per month.
Make the keys in this file the same as the table you want the config to apply to.
This would allow us to turn autoscaling on and off of tables without requiring changing the lambda function code and redeploying it.
If it's there, great! Use it. Otherwise, just stick with the default.
Member
|
Hey, the use case is totally valid. Issue at the moment is that everyones requirements are different and accepting them all into the main repo will quickly turn it into a mess. For this reason in my spare time I've totally refactored the project on my experimental branch, this will allow for better pluggability of custom features. It's not complete yet but support for this kind of thing will definitely be accepted once ready. |
Author
|
Ok that sounds good -- I will just continue to run off of my branch and keep an eye on progress here as best I can :-). Thanks for your quick response, btw! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to be able to autoscale tables based on some autoscaling tag put on the table. This PR allows the end user to either use the default
autoscaledtag name or specify one through an environment variable :-).In addition, I wanted to have a way to keep latency down but still have a way to have custom, moderately flexible, per-table configs. I included the idea of a
CustomProvisionersfile where you could map the keys to the table name you want the config to apply to and have the value for those keys just be a specific version of the default config.Ie:
I'm quite new to dynamo and this autoscaler project in general so any feedback is always appreciated. I tried to design this in a way that would still be backwards compatible to all current defaults.