-
Notifications
You must be signed in to change notification settings - Fork 44
feat(cli): support inline CA certificates in gRPC connections and config #2721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(cli): support inline CA certificates in gRPC connections and config #2721
Conversation
Store CA certificate content (base64-encoded) in config instead of file paths, enabling portable configurations across environments. The gRPC connection layer now accepts CA content directly via WithCAContent option. Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
migmartri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@javirln we need to make sure new clients work with old configuration and the other way around.
In other words, new clients should be compatible with the deprecated path loading
Add unit tests for CA certificate loading functionality including file path detection, PEM content loading, base64-encoded content, and option functions. Tests verify backward compatibility with file paths and new inline content support. Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
Yes, it is. I've added tests for that. It will attempt to load the path, and if successful, store it as base64. Otherwise, It will try to load the base64 directly. |
I don't mean the storing, but the consumption of an already stored path, just to confirm, is that covered? |
Add tests verifying that new clients can consume old configurations with stored file paths, and that the file path detection correctly routes to the legacy loading method. Addresses PR feedback on backward compatibility. Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
Yes, it's backwards compatible with CAs as paths stored in the configuration from all the tests I could ran. |
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
Store CA certificate content (base64-encoded) in config instead of file paths, enabling portable configurations across environments. The gRPC connection layer now accepts CA content directly via WithCAContent option.
PFM-4423