chore(policies): improve error message in policy eval when no branches were executed#2576
Merged
jiparis merged 4 commits intochainloop-dev:mainfrom Nov 25, 2025
Merged
chore(policies): improve error message in policy eval when no branches were executed#2576jiparis merged 4 commits intochainloop-dev:mainfrom
jiparis merged 4 commits intochainloop-dev:mainfrom
Conversation
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
migmartri
approved these changes
Nov 24, 2025
|
|
||
| if len(policyEvs) == 0 || policyEvs[0] == nil { | ||
| return nil, fmt.Errorf("no execution branch matched for kind %s", material.MaterialType.String()) | ||
| return nil, fmt.Errorf("no execution branch matched, or all of them were ignored, for kind %s", material.MaterialType.String()) |
Member
There was a problem hiding this comment.
is there any better way we could do this? I mean, is there any way to distinguish them? Maybe we can add some debug logging so if you run eval with debug you get info about if the execution path was ignored or executed?
Member
Author
There was a problem hiding this comment.
That would be ideal, yes. It has implications in the engine, though. Let me check them
Member
Author
There was a problem hiding this comment.
The message was already there, but a bug prevented it from being shown. Check my comment in the PR
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
Member
Author
|
Check the change in policy_develop_eval.go. I noticed that the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When policy evaluation result is empty, it might happen that the material didn't match, or that the policy logic (Rego) has set the
ignoreflag totrue(because of missing input parameters or any other criteria).