Skip to content

fix(attestation): material annotations output #2502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
migmartri merged 1 commit into from
Oct 31, 2025
Merged

fix(attestation): material annotations output #2502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions app/cli/cmd/attestation_add.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ import (
"github.com/chainloop-dev/chainloop/app/cli/cmd/output"
"github.com/chainloop-dev/chainloop/app/cli/pkg/action"
schemaapi "github.com/chainloop-dev/chainloop/app/controlplane/api/workflowcontract/v1"
"github.com/chainloop-dev/chainloop/pkg/attestation/crafter/materials"
"github.com/chainloop-dev/chainloop/pkg/resourceloader"
)

Expand Down Expand Up @@ -195,9 +194,6 @@ func displayMaterialInfo(status *action.AttestationStatusMaterial, policyEvaluat
if len(status.Material.Annotations) > 0 {
mt.AppendRow(table.Row{"Annotations", "------"})
for _, a := range status.Material.Annotations {
if materials.IsLegacyAnnotation(a.Name) {
Copy link
Member

@jiparis jiparis Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also remove this method, since it's not used anymore.

continue
}
value := a.Value
if value == "" {
value = NotSet
Expand Down
7 changes: 0 additions & 7 deletions app/cli/cmd/attestation_status.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ import (

"github.com/chainloop-dev/chainloop/app/cli/cmd/output"
"github.com/chainloop-dev/chainloop/app/cli/pkg/action"
"github.com/chainloop-dev/chainloop/pkg/attestation/crafter/materials"
"github.com/chainloop-dev/chainloop/pkg/attestation/renderer/chainloop"
)

Expand Down Expand Up @@ -115,9 +114,6 @@ func attestationStatusTableOutput(status *action.AttestationStatusResult, w io.W
if len(status.Annotations) > 0 {
gt.AppendRow(table.Row{"Annotations", "------"})
for _, a := range status.Annotations {
if materials.IsLegacyAnnotation(a.Name) {
continue
}
value := a.Value
if value == "" {
value = NotSet
Expand Down Expand Up @@ -224,9 +220,6 @@ func materialsTable(status *action.AttestationStatusResult, w io.Writer, full bo
if len(m.Annotations) > 0 {
mt.AppendRow(table.Row{"Annotations", "------"})
for _, a := range m.Annotations {
if materials.IsLegacyAnnotation(a.Name) {
continue
}
value := a.Value
if value == "" {
value = NotSet
Expand Down
Loading