feat: add nginx-ingress-controller and nginx build support#2447
Merged
migmartri merged 2 commits intochainloop-dev:mainfrom Sep 26, 2025
Merged
feat: add nginx-ingress-controller and nginx build support#2447migmartri merged 2 commits intochainloop-dev:mainfrom
migmartri merged 2 commits intochainloop-dev:mainfrom
Conversation
Add build configuration for Bitnami nginx-ingress-controller and nginx container images to support Helm chart deployments. This enables building and signing custom versions of these images following the existing pattern used for other Bitnami containers. - Add nginx-ingress-controller v1.12.1 build configuration - Add nginx v1.27.4 build configuration for default backend - Use consistent sparse checkout and versioning approach - Images will be available at ghcr.io/chainloop-dev/chainloop/ Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
migmartri
commented
Sep 25, 2025
| sparse_checkout: bitnami/vault-k8s/1/debian-12 | ||
| ref: 62cb6e1498e873dd9ab92880073a43896b470c4b | ||
| # NGINX Ingress Controller version: 1.12.1 | ||
| - name: NGINX Ingress Controller |
Member
Author
There was a problem hiding this comment.
@javirln I'd appreciate if you could give it a quick check, thanks!
javirln
reviewed
Sep 25, 2025
| # NGINX Ingress Controller version: 1.12.1 | ||
| - name: NGINX Ingress Controller | ||
| image_name: chainloop-dev/chainloop/nginx-ingress-controller | ||
| path: bitnami/nginx-ingress-controller/1.12/debian-12 |
Member
There was a problem hiding this comment.
path: bitnami/nginx-ingress-controller/1/debian-12
sparse_checkout: bitnami/nginx-ingress-controller/1/debian-12
commit: 87b1dc063ce0a75de731cf6757c1cc5c67ab88e1
| image_name: chainloop-dev/chainloop/nginx | ||
| path: bitnami/nginx/1.27/debian-12 | ||
| sparse_checkout: bitnami/nginx/1.27/debian-12 | ||
| ref: 9ad1a44da005cdf487b3e069220da598cff6776c |
Member
There was a problem hiding this comment.
commit: 1c185405602d01ad60b5454908c95b91deb5747a
Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
Member
Author
|
Thank you @javirln, ptal! |
jiparis
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
This PR adds support for building custom nginx-ingress-controller and nginx container images using the existing GitHub Actions workflow. The images will be:
ghcr.io/chainloop-dev/chainloop/nginx-ingress-controllerandghcr.io/chainloop-dev/chainloop/nginxTest plan