feat(cas): Move check of CAS backends to ticker#2411
Merged
javirln merged 4 commits intochainloop-dev:mainfrom Sep 2, 2025
Merged
feat(cas): Move check of CAS backends to ticker#2411javirln merged 4 commits intochainloop-dev:mainfrom
javirln merged 4 commits intochainloop-dev:mainfrom
Conversation
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
Member
Author
|
The removal of the middleware that checks for the CAS backend will removed in a later PR. |
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
jiparis
reviewed
Sep 2, 2025
| } | ||
|
|
||
| // Start begins the periodic checking of CAS backends | ||
| func (c *CASBackendChecker) Start(ctx context.Context, opts *CASBackendCheckerOpts) { |
Member
There was a problem hiding this comment.
Note that this will be run in all pods. Not sure how they can be splitted (other than moving this logic to River)
Member
Author
There was a problem hiding this comment.
Yes, that's a general problem we have with all tickers, right now it will be checked twice
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
jiparis
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces comprehensive support for auditing CAS backend lifecycle events in the control plane. It adds new event types and logic for tracking CAS backend creation, updates, deletion, and status changes, along with corresponding tests and golden files for validation. Additionally, it refactors application wiring to include a background CAS backend checker that runs every 30 min and checks only default CAS backend not including the INLINE ones.
Auditing and Event Tracking Enhancements:
CASBackendCreated,CASBackendUpdated,CASBackendSoftDeleted,CASBackendPermanentDeletedandCASBackendStatusChanged) with detailed payload structures and descriptions inpkg/auditor/events/casbackend.go.Each CAS backend is checked with a default timeout of 10 seconds, sequentially, no parallelism is introduced.