Fix issue with Delete reloading top of Page #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my experience, clicking the delete button on a bit tag, caused the page to reload at the top because it's an anchor tag with an href. This probably shouldn't be an anchor tag, but if it is going to be, we don't want the browser interpreting that click event. So making the `href= "javascript:void(0);"` will stop that. You could also put an `e.stop()` function on the click.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my experience, clicking the delete button on a bit tag, caused the page to reload at the top because it's an anchor tag with an href. This probably shouldn't be an anchor tag, but if it is going to be, we don't want the browser interpreting that click event. So making the
href= "javascript:void(0);"will stop that. You could also put ane.stop()function on the click.