[players] Frame and annotation fixes, profile 2FA card, doc cleanup#2029
Merged
Conversation
We no longer use POEditor. Point contributors at src/locales/ (en.js is the source of truth; other locales are kept in sync from it) and update the "add a language file" steps accordingly. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Surface the fabricjs-psbrush modifiers in the Annotations card: Shift while drawing for a straight line, Ctrl while drawing for a constant-width (pressure-disabled) stroke. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Two root causes made the player render duplicate frames (e.g. frame 31 on a 12fps shot) and report the wrong frame count (85 instead of 41): - It built its frame model on the production fps, ignoring an entity's data.fps override. Resolve the effective fps (entity.data.fps from the matching store map by entity_type_name, falling back to production) in the task mixin and thread it as an fps prop through PreviewPlayer → PreviewViewer → VideoViewer. - The seek targeted the frame boundary (frame * rounded-frameDuration plus a fixed nudge), whose drift tips past ~frame 30 into the previous frame. Seek to the middle of the frame at full fps precision instead. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The password card's save button rendered after the whole card body, so placing the two-factor section inside it pushed "Change password" below 2FA. Split 2FA into a separate card so the button sits under the fields. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Stepping through annotations with , / . landed 1-2 frames off and then lost the next step. The find keys off annotation.time but the jump used annotation.frame - 1, and those disagree: frame is fps-dependent (it goes stale when the fps changes) and is sometimes a zero-padded string. Derive the target frame from the annotation's time instead, so navigation, the landed frame and the displayed drawing all use the same anchor. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems
Solutions