ENT-13829: Errors on missing value and mutually exclusive types in vars promises#63
Draft
SimonThalvorsen wants to merge 3 commits intocfengine:mainfrom
Draft
ENT-13829: Errors on missing value and mutually exclusive types in vars promises#63SimonThalvorsen wants to merge 3 commits intocfengine:mainfrom
SimonThalvorsen wants to merge 3 commits intocfengine:mainfrom
Conversation
…rs promises Signed-off-by: Simon Halvorsen <simon.halvorsen@northern.tech>
olehermanse
reviewed
Apr 13, 2026
| for attr_node in attribute_nodes | ||
| for child in attr_node.children | ||
| if child.type == "attribute_name" | ||
| and vars_attrs.get(_text(child), {}).get("visibility", "") == "promiseType" |
Member
There was a problem hiding this comment.
Please add a comment to explain what visibility means here.
Member
There was a problem hiding this comment.
@SimonThalvorsen AFAICT you are using visibility to try to find out which attributes are mutually exclusive. I don't think that's correct. I don't see anything in the syntax description which covers this, so feel free to add a hardcoded list of the 7 options.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.