Skip to content

ENT-13490: Fixed an assertion failure when attempting to update a non-existent module #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
olehermanse merged 2 commits into from
Nov 6, 2025
Merged

ENT-13490: Fixed an assertion failure when attempting to update a non-existent module #288

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cee7b34
Rewrote a condition, removing a Pyright warning
jakub-nt Nov 6, 2025
93020eb
Simplified code logic
jakub-nt Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions cfbs/commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,12 +597,11 @@ def update_command(to_update):
update_objects = []
for update in to_update:
old_module = config.get_module_from_build(update.name)
assert (
old_module is not None
), 'We\'ve already checked that modules are in config["build"]'

custom_index = old_module is not None and "index" in old_module
index = Index(old_module["index"]) if custom_index else config.index
if old_module is not None and "index" in old_module:
index = Index(old_module["index"])
else:
index = config.index

if not old_module:
index.translate_alias(update)
Expand All @@ -614,8 +613,7 @@ def update_command(to_update):
)
continue

custom_index = old_module is not None and "index" in old_module
index = Index(old_module["index"]) if custom_index else config.index
index = Index(old_module["index"]) if "index" in old_module else config.index

if not old_module:
index.translate_alias(update)
Expand Down