Code quality improvements in preparation for CFE-4089 #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function could be used not just for commits but also for branches or tags, and so the current name is not precisely correct Signed-off-by: jakub-nt <175944085+jakub-nt@users.noreply.github.com>
The comment is outdated after b451f92 Signed-off-by: jakub-nt <175944085+jakub-nt@users.noreply.github.com>
…s commands Signed-off-by: jakub-nt <175944085+jakub-nt@users.noreply.github.com>
Signed-off-by: jakub-nt <175944085+jakub-nt@users.noreply.github.com>
Signed-off-by: jakub-nt <175944085+jakub-nt@users.noreply.github.com>
Signed-off-by: jakub-nt <175944085+jakub-nt@users.noreply.github.com>
Signed-off-by: jakub-nt <175944085+jakub-nt@users.noreply.github.com>
Signed-off-by: jakub-nt <175944085+jakub-nt@users.noreply.github.com>
olehermanse
approved these changes
Oct 31, 2025
| repo_url, commit = repo_url.rsplit("@", 1) | ||
| if not is_a_commit_hash(commit): | ||
| raise CFBSExitError("'%s' is not a commit reference" % commit) | ||
| assert "@" not in repo_url or (repo_url.rindex("@") < repo_url.rindex(".")) |
Member
There was a problem hiding this comment.
Not a big deal, and probably done this way in other places, but to me, using an if looks more readable (close to how I would explain it) rather than the "or" way;
if "@" in repo_url:
assert repo_url.rindex("@") < repo_url.rindex(".")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.