Skip to content

ENT-13116: Implement an option to write file overwrite diffs during a copy build step to a file, and warnings on identical file overwrites #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
olehermanse merged 9 commits into from
Oct 15, 2025
Merged

ENT-13116: Implement an option to write file overwrite diffs during a copy build step to a file, and warnings on identical file overwrites #284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
83ae0cf
Removed unused variable
jakub-nt Sep 24, 2025
52a6fd5
Added type hints
jakub-nt Sep 25, 2025
13ca501
Renamed a function related to `replace` build step
jakub-nt Oct 2, 2025
3dade25
Refactored `_perform_build_step` into separate functions
jakub-nt Oct 2, 2025
d520eef
Removed unnecessary function arguments
jakub-nt Oct 2, 2025
4095eb4
Implemented an option to write file overwrite diffs during a copy bui…
jakub-nt Oct 3, 2025
45633ee
Helper shell command run functions now return the result; fixed `Call…
jakub-nt Oct 6, 2025
33c6dc0
Print the diffs filename during build
jakub-nt Oct 7, 2025
5b25f44
Improved code quality of copy build step dry run functions
jakub-nt Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions cfbs/args.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ class ArgsTypesNamespace(argparse.Namespace):
git_user_email = None # type: Optional[str]
git_commit_message = None # type: Optional[str]
ignore_versions_json = False # type: bool
diffs = None # type: Optional[str]
omit_download = False # type: bool
check_against_git = False # type: bool
minimum_version = None # type: Optional[str]
Expand Down Expand Up @@ -161,6 +162,13 @@ def get_arg_parser(whitespace_for_manual=False):
help="Ignore versions.json. Necessary in case of a custom index or testing changes to the default index.",
action="store_true",
)
parser.add_argument(
"--diffs",
help="Write diffs of files overwritten with a copy build step during 'cfbs build' to the specified file",
nargs="?",
const="diffs.txt",
default=None,
)
parser.add_argument(
"--omit-download",
help="Use existing masterfiles instead of downloading in 'cfbs generate-release-information'",
Expand Down
Loading