Skip to content

Fix Python 3.5 test failures related to Pyright #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
larsewi merged 1 commit into from
Sep 22, 2025
Merged

Fix Python 3.5 test failures related to Pyright #282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/set-up-legacy-python/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,6 @@ runs:
command: pip install -U pip
- name: Install dependencies
run: |
python -m pip install flake8 pyright pytest setuptools wheel
python -m pip install flake8 pytest setuptools wheel
if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
shell: bash
10 changes: 8 additions & 2 deletions .github/workflows/python-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
flake8 . --ignore=E203,W503,E722,E731 --max-complexity=100 --max-line-length=160
- name: Lint with pyright (type checking)
run: |
pyright cfbs
pyright cfbs --pythonversion ${{ matrix.python-version }}
- name: Test with pytest
run: |
pytest
Expand All @@ -64,6 +64,12 @@ jobs:
- uses: actions/checkout@v4
with:
fetch-depth: 0
- uses: actions/setup-node@v5
with:
node-version: 24
- name: Install Pyright
run: |
npm install -g pyright
- name: Set up legacy Python ${{ matrix.python-version }}
uses: ./.github/actions/set-up-legacy-python
with:
Expand All @@ -73,7 +79,7 @@ jobs:
python -m flake8 . --ignore=E203,W503,E722,E731 --max-complexity=100 --max-line-length=160
- name: Lint with pyright (type checking)
run: |
python -m pyright cfbs
pyright cfbs --pythonversion ${{ matrix.python-version }}
- name: Test with pytest
run: |
python -m pytest
Expand Down