Skip to content

CFE-4571: Even prettier cfbs pretty #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
olehermanse merged 9 commits into from
Aug 28, 2025
Merged

CFE-4571: Even prettier cfbs pretty #278

olehermanse merged 9 commits into from
Aug 28, 2025

Conversation

@larsewi
Copy link
Contributor

@larsewi larsewi commented Aug 27, 2025 •
edited
Loading

  • pretty.py: removed unnecessary call to len()
  • pretty.py: un-nested functions to decrease complexity
  • pretty.py: split encoding of list into two functions
  • pretty.py: split encoding of dict into two functions
  • pretty.py: implemented single line encoder for lists
  • pretty.py: implemented single line encoder for dict
  • pretty.py: renamed a variable
  • pretty.py: line length wrapping takes comma into consideration
  • Added unit tests comparing cfbs pretty with output from npm prettier

larsewi added 2 commits August 27, 2025 17:31
@larsewi
pretty.py: removed unnecessary call to len()
7c7238e 
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
@larsewi
pretty.py: un-nested functions to decrease complexity
ba2411a 
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
@larsewi larsewi force-pushed the not-pretty-enough-for-you branch from 1ca4256 to ddfc6c6 Compare August 27, 2025 16:23
@larsewi larsewi changed the title CFE-4571: Is cfbs pretty not pretty enough for you? CFE-4571: Even prettier cfbs pretty Aug 28, 2025
larsewi added 5 commits August 28, 2025 12:11
@larsewi
pretty.py: split encoding of list into two functions
038d0a1 
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
@larsewi
pretty.py: split encoding of dict into two functions
6a5eda9 
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
@larsewi
pretty.py: implemented single line encoder for lists
d4b4c76 
Ticket: CFE-4571
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
@larsewi
pretty.py: implemented single line encoder for dict
4e18abd 
Ticket: CFE-4571
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
@larsewi
pretty.py: renamed a variable
7a395d7 
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
@larsewi larsewi force-pushed the not-pretty-enough-for-you branch 2 times, most recently from fde0bca to 5faaacc Compare August 28, 2025 10:20
@larsewi
pretty.py: line length wrapping takes comma into consideration
d6da25b 
Ticket: CFE-4571
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
@larsewi larsewi force-pushed the not-pretty-enough-for-you branch from 5faaacc to 2583839 Compare August 28, 2025 10:33
@larsewi larsewi marked this pull request as ready for review August 28, 2025 10:37
@larsewi
Added unit tests comparing cfbs pretty with output from npm prettier
d2a3e40 
We saw some cases where cfbs pretty and npm prettier did not agree.
These tests prove that they now agree for those specific cases.

Ticket: CFE-4571
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
@larsewi larsewi force-pushed the not-pretty-enough-for-you branch from 2583839 to d2a3e40 Compare August 28, 2025 10:39
@olehermanse olehermanse merged commit 0723f73 into cfengine:master Aug 28, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@olehermanse olehermanse olehermanse approved these changes

@victormlg victormlg Awaiting requested review from victormlg

+1 more reviewer

@jakub-nt jakub-nt jakub-nt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@larsewi @olehermanse @jakub-nt